You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "aprimadi (via GitHub)" <gi...@apache.org> on 2023/06/17 07:38:45 UTC
[GitHub] [arrow-datafusion] aprimadi opened a new pull request, #6706: Add alias generator to execution props
aprimadi opened a new pull request, #6706:
URL: https://github.com/apache/arrow-datafusion/pull/6706
# Which issue does this PR close?
Closes #.
# Rationale for this change
TODO
# What changes are included in this PR?
TODO
# Are these changes tested?
TODO
# Are there any user-facing changes?
TODO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6706: Move alias generator to per-query execution props
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #6706:
URL: https://github.com/apache/arrow-datafusion/pull/6706#discussion_r1234079794
##########
datafusion/common/src/lib.rs:
##########
@@ -15,6 +15,7 @@
// specific language governing permissions and limitations
// under the License.
+pub mod alias;
Review Comment:
I think putting it in `common` is a reasonable location 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #6706: Move alias generator to per-query execution props
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #6706:
URL: https://github.com/apache/arrow-datafusion/pull/6706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] aprimadi commented on a diff in pull request #6706: Move alias generator to per-query execution props
Posted by "aprimadi (via GitHub)" <gi...@apache.org>.
aprimadi commented on code in PR #6706:
URL: https://github.com/apache/arrow-datafusion/pull/6706#discussion_r1233099085
##########
datafusion/common/src/lib.rs:
##########
@@ -15,6 +15,7 @@
// specific language governing permissions and limitations
// under the License.
+pub mod alias;
Review Comment:
Need suggestion on the best place to put the AliasGenerator code. Currently, I put it in common because it is used in `core`, `optimizer`, and `physical-expr` crate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org