You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by da...@apache.org on 2016/03/24 17:18:13 UTC
cordova-plugin-splashscreen git commit: CB-10895 Transparent
Splashscreen view sometimes remains
Repository: cordova-plugin-splashscreen
Updated Branches:
refs/heads/feature/fade_bug [created] bea0a4e40
CB-10895 Transparent Splashscreen view sometimes remains
github: close#92
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-splashscreen/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-splashscreen/commit/bea0a4e4
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-splashscreen/tree/bea0a4e4
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-splashscreen/diff/bea0a4e4
Branch: refs/heads/feature/fade_bug
Commit: bea0a4e4083f2c19b71606f76a334439b0b17b40
Parents: 41d9ae9
Author: Jeroen Verhoest <je...@cheqroom.com>
Authored: Mon Mar 14 12:32:11 2016 +0100
Committer: daserge <v-...@microsoft.com>
Committed: Thu Mar 24 16:33:23 2016 +0300
----------------------------------------------------------------------
src/ios/CDVSplashScreen.m | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-plugin-splashscreen/blob/bea0a4e4/src/ios/CDVSplashScreen.m
----------------------------------------------------------------------
diff --git a/src/ios/CDVSplashScreen.m b/src/ios/CDVSplashScreen.m
index 407fde2..1d7b955 100644
--- a/src/ios/CDVSplashScreen.m
+++ b/src/ios/CDVSplashScreen.m
@@ -456,7 +456,10 @@
[weakSelf hideViews];
}
completion:^(BOOL finished) {
- if (finished && !_destroyed) {
+ // Always destroy views, otherwise you could have an
+ // invisible splashscreen that is overlayed over your active views
+ // which causes that no touch events are passed
+ if (!_destroyed) {
[weakSelf destroyViews];
// TODO: It might also be nice to have a js event happen here -jm
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org