You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/01/06 05:37:27 UTC
[GitHub] [pulsar] gaozhangmin opened a new pull request #13641: bundle metrics would overwrite loadbalance metrics
gaozhangmin opened a new pull request #13641:
URL: https://github.com/apache/pulsar/pull/13641
### Motivation
#12366 added bundle metrics, But, If we enabled expose these metrics, It would overwrite previous load balancing metrics.
### Modifications
seperate bundle metrics and load balance metrics
### Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
- [ ] `doc-required`
(If you need help on updating docs, create a doc issue)
- [ ] `no-need-doc`
(Please explain why)
- [ ] `doc`
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #13641: Fix bundle metrics would overwrite loadbalance metrics
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #13641:
URL: https://github.com/apache/pulsar/pull/13641#issuecomment-1017966562
@Anonymitaet - thank you. I forgot to switch labels once the docs were added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #13641: bundle metrics would overwrite loadbalance metrics
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #13641:
URL: https://github.com/apache/pulsar/pull/13641#issuecomment-1006316794
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #13641: Fix bundle metrics would overwrite loadbalance metrics
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #13641:
URL: https://github.com/apache/pulsar/pull/13641#issuecomment-1017225130
@michaeljmarshall docs are done in https://github.com/apache/pulsar/pull/12825/files, so I label this PR w/ `doc-added` and remove `doc-required`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #13641: bundle metrics would overwrite loadbalance metrics
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #13641:
URL: https://github.com/apache/pulsar/pull/13641#issuecomment-1009637693
@hangc0276 PTAL at this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #13641: bundle metrics would overwrite loadbalance metrics
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #13641:
URL: https://github.com/apache/pulsar/pull/13641#issuecomment-1006328612
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #13641: bundle metrics would overwrite loadbalance metrics
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #13641:
URL: https://github.com/apache/pulsar/pull/13641#issuecomment-1006356562
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #13641: bundle metrics would overwrite loadbalance metrics
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #13641:
URL: https://github.com/apache/pulsar/pull/13641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #13641: bundle metrics would overwrite loadbalance metrics
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #13641:
URL: https://github.com/apache/pulsar/pull/13641#issuecomment-1016114984
> Great catch. The code looks good to me. Before we merge this, can you please update the documentation? The doc is located here: `site2/docs/reference-metrics.md`.
@michaeljmarshall Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #13641: bundle metrics would overwrite loadbalance metrics
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13641:
URL: https://github.com/apache/pulsar/pull/13641#issuecomment-1006299280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org