You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2019/12/26 15:16:45 UTC

[GitHub] [zeppelin] zjffdu opened a new pull request #3569: [ZEPPELIN-4512]. Move SqlSplitter from jdbc interpreter to zeppelin-interpreter

zjffdu opened a new pull request #3569: [ZEPPELIN-4512]. Move SqlSplitter from jdbc interpreter to zeppelin-interpreter
URL: https://github.com/apache/zeppelin/pull/3569
 
 
   ### What is this PR for?
   
   This PR move the sql split logic from jdbc interpreter to zeppelin-interpreter, so that other interpreter can reuse it. Besides that, it also fix some bugs of sql splitter, and add more unit test to verify it. 
   
   
   ### What type of PR is it?
   [Bug Fix | Refactoring]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * https://jira.apache.org/jira/browse/ZEPPELIN-4512
   
   ### How should this be tested?
   * CI pass
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] zjffdu commented on issue #3569: [ZEPPELIN-4512]. Move SqlSplitter from jdbc interpreter to zeppelin-interpreter

Posted by GitBox <gi...@apache.org>.
zjffdu commented on issue #3569: [ZEPPELIN-4512]. Move SqlSplitter from jdbc interpreter to zeppelin-interpreter
URL: https://github.com/apache/zeppelin/pull/3569#issuecomment-569395825
 
 
   Thanks @alexott Will merge if no more comment

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] zjffdu edited a comment on issue #3569: [ZEPPELIN-4512]. Move SqlSplitter from jdbc interpreter to zeppelin-interpreter

Posted by GitBox <gi...@apache.org>.
zjffdu edited a comment on issue #3569: [ZEPPELIN-4512]. Move SqlSplitter from jdbc interpreter to zeppelin-interpreter
URL: https://github.com/apache/zeppelin/pull/3569#issuecomment-569174283
 
 
   Thanks for the comment @alexott 
   I have updated the PR to allow adding additional single line comment prefix. I am not sure whether's any other places needs to be customized for sql dialect. 
   `SqlSplitterTest#testCustomSplitter_1` and `SqlSplitterTest#testCustomSplitter_2` demonstrate that. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] zjffdu commented on issue #3569: [ZEPPELIN-4512]. Move SqlSplitter from jdbc interpreter to zeppelin-interpreter

Posted by GitBox <gi...@apache.org>.
zjffdu commented on issue #3569: [ZEPPELIN-4512]. Move SqlSplitter from jdbc interpreter to zeppelin-interpreter
URL: https://github.com/apache/zeppelin/pull/3569#issuecomment-569174283
 
 
   Thanks for the comment @alexott 
   I have updated the PR to allow adding additional single line comment prefix. I am not sure whether's any other places needs to be customized for sql dialect. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] asfgit closed pull request #3569: [ZEPPELIN-4512]. Move SqlSplitter from jdbc interpreter to zeppelin-interpreter

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3569: [ZEPPELIN-4512]. Move SqlSplitter from jdbc interpreter to zeppelin-interpreter
URL: https://github.com/apache/zeppelin/pull/3569
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services