[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2908: FINERACT-1840: Fee income is not realised if the loan got fully repaid

["josehernandezfintecheandomx (via GitHub)" <gi...@apache.org>]

josehernandezfintecheandomx commented on code in PR #2908:
URL: https://github.com/apache/fineract/pull/2908#discussion_r1094957248


##########
fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/api/JournalEntriesApiResource.java:
##########
@@ -166,7 +166,7 @@ public String retrieveAll(@Context final UriInfo uriInfo,
             + "journalentries/1?fields=officeName,glAccountId,entryType,amount\n" + "\n" + "journalentries/1?runningBalance=true\n" + "\n"
             + "journalentries/1?transactionDetails=true")
     @ApiResponses({
-            @ApiResponse(responseCode = "200", description = "OK", content = @Content(schema = @Schema(implementation = JournalEntryData.class))) })
+            @ApiResponse(responseCode = "200", description = "OK", content = @Content(schema = @Schema(implementation = JournalEntriesApiResourceSwagger.GetJournalEntriesTransactionIdResponse.class))) })

Review Comment:
   When you get the Journal entries using the Transaction Id, the current endpoint return an array (usually two items) with the gl journal entries but It returns with paging 
   
   <img width="1665" alt="Screenshot 2023-02-02 at 12 56 42" src="https://user-images.githubusercontent.com/44206706/216424960-681a0098-ed7a-4a92-815d-d43171bb6f84.png">
   
   Done, I've renamed the class



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org