[GitHub] williaster commented on a change in pull request #6377: [SIP-5] QueryBuilder in the client for groupby

[GitBox <gi...@apache.org>]

williaster commented on a change in pull request #6377: [SIP-5] QueryBuilder in the client for groupby
URL: https://github.com/apache/incubator-superset/pull/6377#discussion_r232920488
 
 

 ##########
 File path: superset/assets/src/query/datasourceBuilder.ts
 ##########
 @@ -0,0 +1,19 @@
+import { FormData } from './formData';
+
+enum DatasourceType {
+  Table = 'table',
+  Druid = 'druid',
+}
+
+export interface Datasource {
+  id: number;
+  type: DatasourceType;
+}
+
+export default function build(formData: FormData): Datasource {
 
 Review comment:
   could we match the name the file for easier debugging? I want to add the lint rule for this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org