[GitHub] [hadoop] xinglin commented on pull request #5125: HDFS-16838. Fix NPE in testAddRplicaProcessorForAddingReplicaInMap

[GitBox <gi...@apache.org>]

xinglin commented on PR #5125:
URL: https://github.com/apache/hadoop/pull/5125#issuecomment-1312530306

   Instead of the change proposed in this PR, shouldn't we actually fix reInitializeAddReplicaThreadPool() itself as below? 
   
   Current:
   ```
     @VisibleForTesting
     public static void reInitializeAddReplicaThreadPool() {
       addReplicaThreadPool.shutdown();
       addReplicaThreadPool = null;
     }
   ```
   
   Fixed as following:
   ```
     @VisibleForTesting
     public static void reInitializeAddReplicaThreadPool() {
       if (addReplicaThreadPool != null) {
         addReplicaThreadPool.shutdown();
         addReplicaThreadPool = null;
       }
     }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org