Review Request 59334: Prevent creation of core files in dockerized builds.

[Benjamin Bannier <be...@mesosphere.io>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59334/
-----------------------------------------------------------

Review request for Mesos Reviewbot.


Repository: mesos


Description
-------

For autotools build, the docker-build script performs a 'distcheck'
build. This type of build warns if any unexpected files are left in
the build directory after an uninstall, mainly to detect broken
uninstall Makefile rules. The return status of the build container is
the result of the distcheck.

During a build and test run a number of programs are executed, each of
which could in principle produce a core file via a segmentation fault.
During test execution we are not primarily interested in these core
files, but in the exit status of test runs. A test run could e.g.,
have segfaulted, leading to a non-success exit status, and as a
side-effect some core file; if on the other hand, some program invoked
from tests segfaulted and produced a core file we should only consider
this a failure if it lead to some failed test expectation.

This patch suppresses creation of core files since while they might
not be expected, their existence alone should not be considered a
failure. Not creating core files prevents distcheck from treating such
builds as failed.

This fixes an issue where in some dockerized configurations
invocations of 'perf' segfaulted (producing a core file as a
side-effect), where the failure case was already anticipated and
handled by the caller.


Diffs
-----

  support/docker-build.sh d16766b09316bb6ff842a51675bdd6fa9fd748e8 


Diff: https://reviews.apache.org/r/59334/diff/1/


Testing
-------

Tested locally, needs to be confirmed by Apache CI, e.g., reviewbot.


Thanks,

Benjamin Bannier

Re: Review Request 59334: WIP: Prevent creation of core files in dockerized builds.

[Benjamin Bannier <be...@mesosphere.io>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59334/
-----------------------------------------------------------

(Updated May 17, 2017, 1:44 p.m.)


Review request for mesos and Neil Conway.


Summary (updated)
-----------------

WIP: Prevent creation of core files in dockerized builds.


Repository: mesos


Description
-------

For autotools build, the docker-build script performs a 'distcheck'
build. This type of build warns if any unexpected files are left in
the build directory after an uninstall, mainly to detect broken
uninstall Makefile rules. The return status of the build container is
the result of the distcheck.

During a build and test run a number of programs are executed, each of
which could in principle produce a core file via a segmentation fault.
During test execution we are not primarily interested in these core
files, but in the exit status of test runs. A test run could e.g.,
have segfaulted, leading to a non-success exit status, and as a
side-effect some core file; if on the other hand, some program invoked
from tests segfaulted and produced a core file we should only consider
this a failure if it lead to some failed test expectation.

This patch suppresses creation of core files since while they might
not be expected, their existence alone should not be considered a
failure. Not creating core files prevents distcheck from treating such
builds as failed.

This fixes an issue where in some dockerized configurations
invocations of 'perf' segfaulted (producing a core file as a
side-effect), where the failure case was already anticipated and
handled by the caller.


Diffs
-----

  support/docker-build.sh d16766b09316bb6ff842a51675bdd6fa9fd748e8 


Diff: https://reviews.apache.org/r/59334/diff/1/


Testing
-------

Tested locally, needs to be confirmed by Apache CI, e.g., reviewbot.


Thanks,

Benjamin Bannier