You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Steve Loughran (Created) (JIRA)" <ji...@apache.org> on 2012/02/24 16:28:49 UTC
[jira] [Created] (MAPREDUCE-3909) javadoc the
ServiceStateChangeListener callback
javadoc the ServiceStateChangeListener callback
-----------------------------------------------
Key: MAPREDUCE-3909
URL: https://issues.apache.org/jira/browse/MAPREDUCE-3909
Project: Hadoop Map/Reduce
Issue Type: Improvement
Components: mrv2
Affects Versions: 0.23.0, 0.23.1
Reporter: Steve Loughran
Assignee: Steve Loughran
Priority: Trivial
The {{ServiceStateChangeListener}} interface doesn't define when the method is called, whether it is sync or async with a state change etc -you have to look in the code for this.
Document it for others
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3909) javadoc the Service interfaces
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217350#comment-13217350 ]
Hudson commented on MAPREDUCE-3909:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #1796 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1796/])
MAPREDUCE-3909 (Revision 1294219)
Result = ABORTED
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294219
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/ServiceStateChangeListener.java
> javadoc the Service interfaces
> ------------------------------
>
> Key: MAPREDUCE-3909
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3909
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv2
> Affects Versions: 0.23.0, 0.23.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Trivial
> Fix For: 0.24.0, 0.23.3
>
> Attachments: MAPREDUCE-3909.patch, MAPREDUCE-3909.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The {{Service}} interface doesn't describe what it does.
> The {{ServiceStateChangeListener}} interface doesn't define when the method is called, whether it is sync or async with a state change etc -you have to look in the code for this.
> Document for others
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3909) javadoc the Service interfaces
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217297#comment-13217297 ]
Hudson commented on MAPREDUCE-3909:
-----------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #1859 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1859/])
MAPREDUCE-3909 (Revision 1294219)
Result = SUCCESS
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294219
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/ServiceStateChangeListener.java
> javadoc the Service interfaces
> ------------------------------
>
> Key: MAPREDUCE-3909
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3909
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv2
> Affects Versions: 0.23.0, 0.23.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Trivial
> Fix For: 0.24.0, 0.23.3
>
> Attachments: MAPREDUCE-3909.patch, MAPREDUCE-3909.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The {{Service}} interface doesn't describe what it does.
> The {{ServiceStateChangeListener}} interface doesn't define when the method is called, whether it is sync or async with a state change etc -you have to look in the code for this.
> Document for others
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3909) javadoc the
ServiceStateChangeListener callback
Posted by "Steve Loughran (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated MAPREDUCE-3909:
--------------------------------------
Status: Patch Available (was: Open)
> javadoc the ServiceStateChangeListener callback
> -----------------------------------------------
>
> Key: MAPREDUCE-3909
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3909
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv2
> Affects Versions: 0.23.0, 0.23.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Trivial
> Attachments: MAPREDUCE-3909.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The {{ServiceStateChangeListener}} interface doesn't define when the method is called, whether it is sync or async with a state change etc -you have to look in the code for this.
> Document it for others
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3909) javadoc the Service interfaces
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215736#comment-13215736 ]
Hadoop QA commented on MAPREDUCE-3909:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12515933/MAPREDUCE-3909.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1924//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1924//console
This message is automatically generated.
> javadoc the Service interfaces
> ------------------------------
>
> Key: MAPREDUCE-3909
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3909
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv2
> Affects Versions: 0.23.0, 0.23.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Trivial
> Attachments: MAPREDUCE-3909.patch, MAPREDUCE-3909.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The {{Service}} interface doesn't describe what it does.
> The {{ServiceStateChangeListener}} interface doesn't define when the method is called, whether it is sync or async with a state change etc -you have to look in the code for this.
> Document for others
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3909) javadoc the Service interfaces
Posted by "Steve Loughran (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated MAPREDUCE-3909:
--------------------------------------
Attachment: MAPREDUCE-3909.patch
javadocs for Service, ServiceStateChangeListener, and AbstractService
> javadoc the Service interfaces
> ------------------------------
>
> Key: MAPREDUCE-3909
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3909
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv2
> Affects Versions: 0.23.0, 0.23.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Trivial
> Attachments: MAPREDUCE-3909.patch, MAPREDUCE-3909.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The {{Service}} interface doesn't describe what it does.
> The {{ServiceStateChangeListener}} interface doesn't define when the method is called, whether it is sync or async with a state change etc -you have to look in the code for this.
> Document for others
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3909) javadoc the Service interfaces
Posted by "Steve Loughran (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated MAPREDUCE-3909:
--------------------------------------
Resolution: Fixed
Fix Version/s: 0.23.3
0.24.0
Target Version/s: 0.24.0, 0.23.2 (was: 0.23.2, 0.24.0)
Status: Resolved (was: Patch Available)
> javadoc the Service interfaces
> ------------------------------
>
> Key: MAPREDUCE-3909
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3909
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv2
> Affects Versions: 0.23.0, 0.23.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Trivial
> Fix For: 0.24.0, 0.23.3
>
> Attachments: MAPREDUCE-3909.patch, MAPREDUCE-3909.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The {{Service}} interface doesn't describe what it does.
> The {{ServiceStateChangeListener}} interface doesn't define when the method is called, whether it is sync or async with a state change etc -you have to look in the code for this.
> Document for others
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3909) javadoc the Service interfaces
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218167#comment-13218167 ]
Hudson commented on MAPREDUCE-3909:
-----------------------------------
Integrated in Hadoop-Mapreduce-0.23-Build #210 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/210/])
MAPREDUCE-3909 (Revision 1294220)
Result = FAILURE
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294220
Files :
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/ServiceStateChangeListener.java
> javadoc the Service interfaces
> ------------------------------
>
> Key: MAPREDUCE-3909
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3909
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv2
> Affects Versions: 0.23.0, 0.23.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Trivial
> Fix For: 0.24.0, 0.23.3
>
> Attachments: MAPREDUCE-3909.patch, MAPREDUCE-3909.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The {{Service}} interface doesn't describe what it does.
> The {{ServiceStateChangeListener}} interface doesn't define when the method is called, whether it is sync or async with a state change etc -you have to look in the code for this.
> Document for others
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3909) javadoc the
ServiceStateChangeListener callback
Posted by "Steve Loughran (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated MAPREDUCE-3909:
--------------------------------------
Attachment: MAPREDUCE-3909.patch
> javadoc the ServiceStateChangeListener callback
> -----------------------------------------------
>
> Key: MAPREDUCE-3909
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3909
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv2
> Affects Versions: 0.23.0, 0.23.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Trivial
> Attachments: MAPREDUCE-3909.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The {{ServiceStateChangeListener}} interface doesn't define when the method is called, whether it is sync or async with a state change etc -you have to look in the code for this.
> Document it for others
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3909) javadoc the Service interfaces
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218121#comment-13218121 ]
Hudson commented on MAPREDUCE-3909:
-----------------------------------
Integrated in Hadoop-Hdfs-trunk #969 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/969/])
MAPREDUCE-3909 (Revision 1294219)
Result = UNSTABLE
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294219
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/ServiceStateChangeListener.java
> javadoc the Service interfaces
> ------------------------------
>
> Key: MAPREDUCE-3909
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3909
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv2
> Affects Versions: 0.23.0, 0.23.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Trivial
> Fix For: 0.24.0, 0.23.3
>
> Attachments: MAPREDUCE-3909.patch, MAPREDUCE-3909.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The {{Service}} interface doesn't describe what it does.
> The {{ServiceStateChangeListener}} interface doesn't define when the method is called, whether it is sync or async with a state change etc -you have to look in the code for this.
> Document for others
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3909) javadoc the Service interfaces
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217349#comment-13217349 ]
Hudson commented on MAPREDUCE-3909:
-----------------------------------
Integrated in Hadoop-Mapreduce-0.23-Commit #602 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/602/])
MAPREDUCE-3909 (Revision 1294220)
Result = ABORTED
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294220
Files :
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/ServiceStateChangeListener.java
> javadoc the Service interfaces
> ------------------------------
>
> Key: MAPREDUCE-3909
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3909
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv2
> Affects Versions: 0.23.0, 0.23.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Trivial
> Fix For: 0.24.0, 0.23.3
>
> Attachments: MAPREDUCE-3909.patch, MAPREDUCE-3909.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The {{Service}} interface doesn't describe what it does.
> The {{ServiceStateChangeListener}} interface doesn't define when the method is called, whether it is sync or async with a state change etc -you have to look in the code for this.
> Document for others
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3909) javadoc the Service interfaces
Posted by "Steve Loughran (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated MAPREDUCE-3909:
--------------------------------------
Description:
The {{Service}} interface doesn't describe what it does.
The {{ServiceStateChangeListener}} interface doesn't define when the method is called, whether it is sync or async with a state change etc -you have to look in the code for this.
Document for others
was:
The {{ServiceStateChangeListener}} interface doesn't define when the method is called, whether it is sync or async with a state change etc -you have to look in the code for this.
Document it for others
Summary: javadoc the Service interfaces (was: javadoc the ServiceStateChangeListener callback)
> javadoc the Service interfaces
> ------------------------------
>
> Key: MAPREDUCE-3909
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3909
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv2
> Affects Versions: 0.23.0, 0.23.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Trivial
> Attachments: MAPREDUCE-3909.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The {{Service}} interface doesn't describe what it does.
> The {{ServiceStateChangeListener}} interface doesn't define when the method is called, whether it is sync or async with a state change etc -you have to look in the code for this.
> Document for others
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3909) javadoc the Service interfaces
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215723#comment-13215723 ]
Hadoop QA commented on MAPREDUCE-3909:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12515928/MAPREDUCE-3909.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1923//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1923//console
This message is automatically generated.
> javadoc the Service interfaces
> ------------------------------
>
> Key: MAPREDUCE-3909
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3909
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv2
> Affects Versions: 0.23.0, 0.23.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Trivial
> Attachments: MAPREDUCE-3909.patch, MAPREDUCE-3909.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The {{Service}} interface doesn't describe what it does.
> The {{ServiceStateChangeListener}} interface doesn't define when the method is called, whether it is sync or async with a state change etc -you have to look in the code for this.
> Document for others
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3909) javadoc the Service interfaces
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217302#comment-13217302 ]
Hudson commented on MAPREDUCE-3909:
-----------------------------------
Integrated in Hadoop-Common-trunk-Commit #1785 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1785/])
MAPREDUCE-3909 (Revision 1294219)
Result = SUCCESS
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294219
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/ServiceStateChangeListener.java
> javadoc the Service interfaces
> ------------------------------
>
> Key: MAPREDUCE-3909
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3909
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv2
> Affects Versions: 0.23.0, 0.23.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Trivial
> Fix For: 0.24.0, 0.23.3
>
> Attachments: MAPREDUCE-3909.patch, MAPREDUCE-3909.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The {{Service}} interface doesn't describe what it does.
> The {{ServiceStateChangeListener}} interface doesn't define when the method is called, whether it is sync or async with a state change etc -you have to look in the code for this.
> Document for others
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3909) javadoc the Service interfaces
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218113#comment-13218113 ]
Hudson commented on MAPREDUCE-3909:
-----------------------------------
Integrated in Hadoop-Hdfs-0.23-Build #182 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/182/])
MAPREDUCE-3909 (Revision 1294220)
Result = SUCCESS
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294220
Files :
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/ServiceStateChangeListener.java
> javadoc the Service interfaces
> ------------------------------
>
> Key: MAPREDUCE-3909
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3909
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv2
> Affects Versions: 0.23.0, 0.23.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Trivial
> Fix For: 0.24.0, 0.23.3
>
> Attachments: MAPREDUCE-3909.patch, MAPREDUCE-3909.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The {{Service}} interface doesn't describe what it does.
> The {{ServiceStateChangeListener}} interface doesn't define when the method is called, whether it is sync or async with a state change etc -you have to look in the code for this.
> Document for others
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3909) javadoc the Service interfaces
Posted by "Steve Loughran (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated MAPREDUCE-3909:
--------------------------------------
Target Version/s: 0.24.0, 0.23.2
Status: Patch Available (was: Open)
this is only javadocs, no tests or code changes apart from removing a trailing ; on the state enum (the IDE was complaining)
> javadoc the Service interfaces
> ------------------------------
>
> Key: MAPREDUCE-3909
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3909
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv2
> Affects Versions: 0.23.0, 0.23.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Trivial
> Attachments: MAPREDUCE-3909.patch, MAPREDUCE-3909.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The {{Service}} interface doesn't describe what it does.
> The {{ServiceStateChangeListener}} interface doesn't define when the method is called, whether it is sync or async with a state change etc -you have to look in the code for this.
> Document for others
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3909) javadoc the Service interfaces
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217288#comment-13217288 ]
Hudson commented on MAPREDUCE-3909:
-----------------------------------
Integrated in Hadoop-Hdfs-0.23-Commit #588 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/588/])
MAPREDUCE-3909 (Revision 1294220)
Result = SUCCESS
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294220
Files :
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/ServiceStateChangeListener.java
> javadoc the Service interfaces
> ------------------------------
>
> Key: MAPREDUCE-3909
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3909
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv2
> Affects Versions: 0.23.0, 0.23.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Trivial
> Fix For: 0.24.0, 0.23.3
>
> Attachments: MAPREDUCE-3909.patch, MAPREDUCE-3909.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The {{Service}} interface doesn't describe what it does.
> The {{ServiceStateChangeListener}} interface doesn't define when the method is called, whether it is sync or async with a state change etc -you have to look in the code for this.
> Document for others
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3909) javadoc the Service interfaces
Posted by "Steve Loughran (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated MAPREDUCE-3909:
--------------------------------------
Status: Open (was: Patch Available)
> javadoc the Service interfaces
> ------------------------------
>
> Key: MAPREDUCE-3909
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3909
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv2
> Affects Versions: 0.23.0, 0.23.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Trivial
> Attachments: MAPREDUCE-3909.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The {{Service}} interface doesn't describe what it does.
> The {{ServiceStateChangeListener}} interface doesn't define when the method is called, whether it is sync or async with a state change etc -you have to look in the code for this.
> Document for others
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3909) javadoc the Service interfaces
Posted by "Sharad Agarwal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217121#comment-13217121 ]
Sharad Agarwal commented on MAPREDUCE-3909:
-------------------------------------------
+1
> javadoc the Service interfaces
> ------------------------------
>
> Key: MAPREDUCE-3909
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3909
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv2
> Affects Versions: 0.23.0, 0.23.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Trivial
> Attachments: MAPREDUCE-3909.patch, MAPREDUCE-3909.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The {{Service}} interface doesn't describe what it does.
> The {{ServiceStateChangeListener}} interface doesn't define when the method is called, whether it is sync or async with a state change etc -you have to look in the code for this.
> Document for others
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3909) javadoc the Service interfaces
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218210#comment-13218210 ]
Hudson commented on MAPREDUCE-3909:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk #1004 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1004/])
MAPREDUCE-3909 (Revision 1294219)
Result = SUCCESS
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294219
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/ServiceStateChangeListener.java
> javadoc the Service interfaces
> ------------------------------
>
> Key: MAPREDUCE-3909
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3909
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv2
> Affects Versions: 0.23.0, 0.23.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Trivial
> Fix For: 0.24.0, 0.23.3
>
> Attachments: MAPREDUCE-3909.patch, MAPREDUCE-3909.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The {{Service}} interface doesn't describe what it does.
> The {{ServiceStateChangeListener}} interface doesn't define when the method is called, whether it is sync or async with a state change etc -you have to look in the code for this.
> Document for others
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3909) javadoc the Service interfaces
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217299#comment-13217299 ]
Hudson commented on MAPREDUCE-3909:
-----------------------------------
Integrated in Hadoop-Common-0.23-Commit #601 (See [https://builds.apache.org/job/Hadoop-Common-0.23-Commit/601/])
MAPREDUCE-3909 (Revision 1294220)
Result = SUCCESS
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1294220
Files :
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/ServiceStateChangeListener.java
> javadoc the Service interfaces
> ------------------------------
>
> Key: MAPREDUCE-3909
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3909
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv2
> Affects Versions: 0.23.0, 0.23.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Trivial
> Fix For: 0.24.0, 0.23.3
>
> Attachments: MAPREDUCE-3909.patch, MAPREDUCE-3909.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The {{Service}} interface doesn't describe what it does.
> The {{ServiceStateChangeListener}} interface doesn't define when the method is called, whether it is sync or async with a state change etc -you have to look in the code for this.
> Document for others
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira