You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by ri...@apache.org on 2022/02/02 18:43:02 UTC
[geode] branch GEODE-10013-Remove-Unused-Code-In-Geode-for-Redis-Tests created (now 0382607)
This is an automated email from the ASF dual-hosted git repository.
ringles pushed a change to branch GEODE-10013-Remove-Unused-Code-In-Geode-for-Redis-Tests
in repository https://gitbox.apache.org/repos/asf/geode.git.
at 0382607 Initial commit
This branch includes the following new commits:
new 0382607 Initial commit
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[geode] 01/01: Initial commit
Posted by ri...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ringles pushed a commit to branch GEODE-10013-Remove-Unused-Code-In-Geode-for-Redis-Tests
in repository https://gitbox.apache.org/repos/asf/geode.git
commit 0382607d40a49087bb36d2c2bcdfc66e6b36f125
Author: Ray Ingles <ri...@vmware.com>
AuthorDate: Wed Feb 2 13:41:27 2022 -0500
Initial commit
---
.../internal/commands/executor/hash/HExistsDUnitTest.java | 3 ---
.../internal/commands/executor/hash/HGetDUnitTest.java | 3 ---
.../internal/commands/executor/hash/HKeysDUnitTest.java | 4 ----
.../internal/commands/executor/hash/HMgetDUnitTest.java | 3 ---
.../internal/commands/executor/hash/HMsetDUnitTest.java | 4 ----
.../internal/commands/executor/hash/HsetDUnitTest.java | 4 ----
.../internal/commands/executor/key/ExpireDUnitTest.java | 4 ----
.../executor/pubsub/PubSubConcurrentDUnitTest.java | 2 --
.../internal/commands/executor/pubsub/PubSubDUnitTest.java | 6 ------
.../internal/commands/executor/set/SaddDUnitTest.java | 4 ----
.../internal/commands/executor/set/SremDUnitTest.java | 4 ----
.../executor/hash/AbstractHashesIntegrationTest.java | 14 --------------
.../commands/executor/set/AbstractSetsIntegrationTest.java | 13 -------------
13 files changed, 68 deletions(-)
diff --git a/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/hash/HExistsDUnitTest.java b/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/hash/HExistsDUnitTest.java
index 6301038..3b405c9 100644
--- a/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/hash/HExistsDUnitTest.java
+++ b/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/hash/HExistsDUnitTest.java
@@ -68,9 +68,6 @@ public class HExistsDUnitTest {
@AfterClass
public static void tearDown() {
jedis.close();
-
- server1.stop();
- server2.stop();
}
@Test
diff --git a/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/hash/HGetDUnitTest.java b/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/hash/HGetDUnitTest.java
index 8dbbd65..f078f0a 100644
--- a/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/hash/HGetDUnitTest.java
+++ b/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/hash/HGetDUnitTest.java
@@ -66,9 +66,6 @@ public class HGetDUnitTest {
@AfterClass
public static void tearDown() {
jedis.close();
-
- server1.stop();
- server2.stop();
}
@Test
diff --git a/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/hash/HKeysDUnitTest.java b/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/hash/HKeysDUnitTest.java
index e0af08a..5a45f4d 100644
--- a/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/hash/HKeysDUnitTest.java
+++ b/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/hash/HKeysDUnitTest.java
@@ -72,10 +72,6 @@ public class HKeysDUnitTest {
@AfterClass
public static void tearDown() {
jedis.close();
-
- server1.stop();
- server2.stop();
- locator.stop();
}
@Test
diff --git a/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/hash/HMgetDUnitTest.java b/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/hash/HMgetDUnitTest.java
index f33ac72..e369b8b 100644
--- a/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/hash/HMgetDUnitTest.java
+++ b/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/hash/HMgetDUnitTest.java
@@ -66,9 +66,6 @@ public class HMgetDUnitTest {
@AfterClass
public static void tearDown() {
jedis.close();
-
- server1.stop();
- server2.stop();
}
@Test
diff --git a/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/hash/HMsetDUnitTest.java b/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/hash/HMsetDUnitTest.java
index 4c85681..74de352 100644
--- a/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/hash/HMsetDUnitTest.java
+++ b/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/hash/HMsetDUnitTest.java
@@ -69,10 +69,6 @@ public class HMsetDUnitTest {
@AfterClass
public static void tearDown() {
jedis.close();
-
- server1.stop();
- server2.stop();
- server3.stop();
}
diff --git a/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/hash/HsetDUnitTest.java b/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/hash/HsetDUnitTest.java
index c417109..9495968 100644
--- a/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/hash/HsetDUnitTest.java
+++ b/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/hash/HsetDUnitTest.java
@@ -69,10 +69,6 @@ public class HsetDUnitTest {
@AfterClass
public static void tearDown() {
jedis.close();
-
- server1.stop();
- server2.stop();
- server3.stop();
}
@Test
diff --git a/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/key/ExpireDUnitTest.java b/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/key/ExpireDUnitTest.java
index 8cb603f..d77c3cc 100644
--- a/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/key/ExpireDUnitTest.java
+++ b/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/key/ExpireDUnitTest.java
@@ -63,10 +63,6 @@ public class ExpireDUnitTest {
@AfterClass
public static void tearDown() {
jedis.close();
-
- server1.stop();
- server2.stop();
- server3.stop();
}
@Test
diff --git a/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/pubsub/PubSubConcurrentDUnitTest.java b/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/pubsub/PubSubConcurrentDUnitTest.java
index 49f5c83..dd5185f 100644
--- a/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/pubsub/PubSubConcurrentDUnitTest.java
+++ b/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/pubsub/PubSubConcurrentDUnitTest.java
@@ -122,8 +122,6 @@ public class PubSubConcurrentDUnitTest {
@After
public void tearDown() {
- server1.stop();
- server2.stop();
subscriberVM.invoke(() -> {
subscribers.clear();
mockSubscribers.clear();
diff --git a/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/pubsub/PubSubDUnitTest.java b/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/pubsub/PubSubDUnitTest.java
index 2851763..7757c22 100644
--- a/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/pubsub/PubSubDUnitTest.java
+++ b/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/pubsub/PubSubDUnitTest.java
@@ -131,12 +131,6 @@ public class PubSubDUnitTest {
subscriber2.disconnect();
publisher1.disconnect();
publisher2.disconnect();
-
- server1.stop();
- server2.stop();
- server3.stop();
- server4.stop();
- server5.stop();
}
@Test
diff --git a/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/set/SaddDUnitTest.java b/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/set/SaddDUnitTest.java
index 418583d..69ce81c 100644
--- a/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/set/SaddDUnitTest.java
+++ b/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/set/SaddDUnitTest.java
@@ -69,10 +69,6 @@ public class SaddDUnitTest {
@AfterClass
public static void tearDown() {
jedis.close();
-
- server1.stop();
- server2.stop();
- server3.stop();
}
@Test
diff --git a/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/set/SremDUnitTest.java b/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/set/SremDUnitTest.java
index 8e24338..ae491c4 100644
--- a/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/set/SremDUnitTest.java
+++ b/geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/set/SremDUnitTest.java
@@ -69,10 +69,6 @@ public class SremDUnitTest {
@AfterClass
public static void tearDown() {
jedis.close();
-
- server1.stop();
- server2.stop();
- server3.stop();
}
diff --git a/geode-for-redis/src/integrationTest/java/org/apache/geode/redis/internal/commands/executor/hash/AbstractHashesIntegrationTest.java b/geode-for-redis/src/integrationTest/java/org/apache/geode/redis/internal/commands/executor/hash/AbstractHashesIntegrationTest.java
index bedac70..42f71b3 100755
--- a/geode-for-redis/src/integrationTest/java/org/apache/geode/redis/internal/commands/executor/hash/AbstractHashesIntegrationTest.java
+++ b/geode-for-redis/src/integrationTest/java/org/apache/geode/redis/internal/commands/executor/hash/AbstractHashesIntegrationTest.java
@@ -880,20 +880,6 @@ public abstract class AbstractHashesIntegrationTest implements RedisIntegrationT
}
@Test
- public void testHset_canStoreBinaryData() {
- byte[] blob = new byte[256];
- for (int i = 0; i < 256; i++) {
- blob[i] = (byte) i;
- }
-
- jedis.hset("key".getBytes(), blob, blob);
- Map<byte[], byte[]> result = jedis.hgetAll("key".getBytes());
-
- assertThat(result.keySet()).containsExactly(blob);
- assertThat(result.values()).containsExactly(blob);
- }
-
- @Test
public void testHstrlen_withBinaryData() {
byte[] zero = new byte[] {0};
jedis.hset(zero, zero, zero);
diff --git a/geode-for-redis/src/integrationTest/java/org/apache/geode/redis/internal/commands/executor/set/AbstractSetsIntegrationTest.java b/geode-for-redis/src/integrationTest/java/org/apache/geode/redis/internal/commands/executor/set/AbstractSetsIntegrationTest.java
index e40b5cb..72973d2 100755
--- a/geode-for-redis/src/integrationTest/java/org/apache/geode/redis/internal/commands/executor/set/AbstractSetsIntegrationTest.java
+++ b/geode-for-redis/src/integrationTest/java/org/apache/geode/redis/internal/commands/executor/set/AbstractSetsIntegrationTest.java
@@ -85,19 +85,6 @@ public abstract class AbstractSetsIntegrationTest implements RedisIntegrationTes
}
@Test
- public void testSAdd_canStoreBinaryData() {
- byte[] blob = new byte[256];
- for (int i = 0; i < 256; i++) {
- blob[i] = (byte) i;
- }
-
- jedis.sadd("key".getBytes(), blob, blob);
- Set<byte[]> result = jedis.smembers("key".getBytes());
-
- assertThat(result).containsExactly(blob);
- }
-
- @Test
public void smembers_givenKeyNotProvided_returnsWrongNumberOfArgumentsError() {
assertThatThrownBy(() -> jedis.sendCommand("key", Protocol.Command.SMEMBERS))
.hasMessageContaining("ERR wrong number of arguments for 'smembers' command");