You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/19 18:09:04 UTC

[GitHub] [beam] jrmccluskey commented on a diff in pull request #17392: [BEAM-14286] Remove unused vars in harness package

jrmccluskey commented on code in PR #17392:
URL: https://github.com/apache/beam/pull/17392#discussion_r853354473


##########
sdks/go/pkg/beam/core/runtime/harness/init/init.go:
##########
@@ -43,7 +43,6 @@ var (
 	loggingEndpoint = flag.String("logging_endpoint", "", "Local logging gRPC endpoint (required in worker mode).")
 	controlEndpoint = flag.String("control_endpoint", "", "Local control gRPC endpoint (required in worker mode).")
 	statusEndpoint  = flag.String("status_endpoint", "", "Local status gRPC endpoint (optional in worker mode).")
-	semiPersistDir  = flag.String("semi_persist_dir", "/tmp", "Local semi-persistent directory (optional in worker mode).")

Review Comment:
   Restored flag with a lint:ignore for now. Should turn the portable precommit green



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org