You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Chandan Purushothama <Ch...@citrix.com> on 2014/12/02 23:40:05 UTC
Review Request 28611: CLOUDSTACK-8007: Fixed the script
'test_vm_passwdenabled.py' - Template created by Admin should have public
access to be used for regular User VM Deployment
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28611/
-----------------------------------------------------------
Review request for cloudstack and sangeetha hariharan.
Bugs: CLOUDSTACK-8007
https://issues.apache.org/jira/browse/CLOUDSTACK-8007
Repository: cloudstack-git
Description
-------
Based on Fix for CLOUDSTACK-7394, Caller should be owner after creating template from snapshot/volume. Since the Admin created the template from the Volume, the Admin is the owner of the private template. In order to deploy a VM for the Regular Account the template created by Admin should have public Access.
Diffs
-----
test/integration/component/test_vm_passwdenabled.py 1b556da
Diff: https://reviews.apache.org/r/28611/diff/
Testing
-------
Test get VM password for password enabled template ... === TestName: test_11_get_vm_password | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 706.715s
OK
Thanks,
Chandan Purushothama
Re: Review Request 28611: CLOUDSTACK-8007: Fixed the script
'test_vm_passwdenabled.py' - Template created by Admin should have public
access to be used for regular User VM Deployment
Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28611/#review79004
-----------------------------------------------------------
Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board.
We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted).
Please consider submitting a pull request.
Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md
Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more.
- Sebastien Goasguen
On Dec. 2, 2014, 10:40 p.m., Chandan Purushothama wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28611/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2014, 10:40 p.m.)
>
>
> Review request for cloudstack and sangeetha hariharan.
>
>
> Bugs: CLOUDSTACK-8007
> https://issues.apache.org/jira/browse/CLOUDSTACK-8007
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Based on Fix for CLOUDSTACK-7394, Caller should be owner after creating template from snapshot/volume. Since the Admin created the template from the Volume, the Admin is the owner of the private template. In order to deploy a VM for the Regular Account the template created by Admin should have public Access.
>
>
> Diffs
> -----
>
> test/integration/component/test_vm_passwdenabled.py 1b556da
>
> Diff: https://reviews.apache.org/r/28611/diff/
>
>
> Testing
> -------
>
> Test get VM password for password enabled template ... === TestName: test_11_get_vm_password | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 706.715s
>
> OK
>
>
> Thanks,
>
> Chandan Purushothama
>
>
Re: Review Request 28611: CLOUDSTACK-8007: Fixed the script
'test_vm_passwdenabled.py' - Template created by Admin should have public
access to be used for regular User VM Deployment
Posted by sangeetha hariharan <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28611/#review63866
-----------------------------------------------------------
Ship it!
Ship It!
- sangeetha hariharan
On Dec. 2, 2014, 10:40 p.m., Chandan Purushothama wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28611/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2014, 10:40 p.m.)
>
>
> Review request for cloudstack and sangeetha hariharan.
>
>
> Bugs: CLOUDSTACK-8007
> https://issues.apache.org/jira/browse/CLOUDSTACK-8007
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Based on Fix for CLOUDSTACK-7394, Caller should be owner after creating template from snapshot/volume. Since the Admin created the template from the Volume, the Admin is the owner of the private template. In order to deploy a VM for the Regular Account the template created by Admin should have public Access.
>
>
> Diffs
> -----
>
> test/integration/component/test_vm_passwdenabled.py 1b556da
>
> Diff: https://reviews.apache.org/r/28611/diff/
>
>
> Testing
> -------
>
> Test get VM password for password enabled template ... === TestName: test_11_get_vm_password | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 706.715s
>
> OK
>
>
> Thanks,
>
> Chandan Purushothama
>
>