You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2018/06/11 16:22:52 UTC

[GitHub] flink pull request #6090: [FLINK-8863] [SQL] Add user-defined function suppo...

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6090#discussion_r194451816
  
    --- Diff: flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/ExecutionContext.java ---
    @@ -101,6 +110,16 @@ public ExecutionContext(Environment defaultEnvironment, SessionContext sessionCo
     			}
     		});
     
    +		// generate user-defined functions
    +		functions = new HashMap<>();
    +		mergedEnv.getFunctions().forEach((name, descriptor) -> {
    +			DescriptorProperties properties = new DescriptorProperties(true);
    +			descriptor.addProperties(properties);
    +			functions.put(
    +					name,
    +					FunctionValidator.generateUserDefinedFunction(properties, classLoader));
    --- End diff --
    
    Maybe move the generation logic from `FunctionValidator.generateUserDefinedFunction` to some class `FunctionService`?


---