You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by jo...@apache.org on 2017/01/24 10:29:35 UTC
zeppelin git commit: [ZEPPELIN-1983] Feedback about success/failure when interpreter is re…
Repository: zeppelin
Updated Branches:
refs/heads/master 3bbcf0969 -> e43585805
[ZEPPELIN-1983] Feedback about success/failure when interpreter is re\u2026
### What is this PR for?
When a interpreter is restarted, there is no feedback to user whether the action is received/honoured by zeppelin. This might also lead them to click restart multiple times, before they realize it has taken affect.
Also fixed a null bug.
### What type of PR is it?
[Improvement + Bug fix]
### Todos
* None
### What is the Jira issue?
ZEPPELIN-1983
### How should this be tested?
Restart a interpreter to test the positive case. The message should disappers on its own after sometime if not closed. A simple way to test the negative case is to stop the server and then try restarting.
### Screenshots (if appropriate)
#### Positive case
#### Negative case
### Questions:
* Does the licenses files need update?
-No
* Is there breaking changes for older versions?
-No
* Does this needs documentation?
-No
Author: Beria <be...@qubole.com>
Closes #1914 from beriaanirudh/ZEPPELIN-1983 and squashes the following commits:
761b986 [Beria] [ZEPPELIN-1983] Feedback about success/failure when interpreter is restarted
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/e4358580
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/e4358580
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/e4358580
Branch: refs/heads/master
Commit: e43585805215f14e254f35d4d61bdb1addff95d1
Parents: 3bbcf09
Author: Beria <be...@qubole.com>
Authored: Fri May 6 10:02:02 2016 +0530
Committer: Jongyoul Lee <jo...@apache.org>
Committed: Tue Jan 24 19:29:22 2017 +0900
----------------------------------------------------------------------
zeppelin-web/src/app/interpreter/interpreter.controller.js | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/e4358580/zeppelin-web/src/app/interpreter/interpreter.controller.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/interpreter/interpreter.controller.js b/zeppelin-web/src/app/interpreter/interpreter.controller.js
index f73bc98..3c9ec01 100644
--- a/zeppelin-web/src/app/interpreter/interpreter.controller.js
+++ b/zeppelin-web/src/app/interpreter/interpreter.controller.js
@@ -424,8 +424,11 @@ function InterpreterCtrl($rootScope, $scope, $http, baseUrlSrv, ngToast, $timeou
.success(function(data, status, headers, config) {
var index = _.findIndex($scope.interpreterSettings, {'id': settingId});
$scope.interpreterSettings[index] = data.body;
+ ngToast.info('Interpreter stopped. Will be lazily started on next run.');
}).error(function(data, status, headers, config) {
- console.log('Error %o %o', status, data.message);
+ var errorMsg = (data !== null) ? data.message : 'Could not connect to server.';
+ console.log('Error %o %o', status, errorMsg);
+ ngToast.danger(errorMsg);
});
}
}