[jira] [Commented] (IGNITE-6528) Warning if no table for BinaryObject

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-6528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454223#comment-16454223 ] 

ASF GitHub Bot commented on IGNITE-6528:
----------------------------------------

GitHub user alamar opened a pull request:

    https://github.com/apache/ignite/pull/3923

    IGNITE-6528 Print warnings when actual data type not equal to expected Indexed Type.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-6528

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/3923.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3923
    
----
commit 925ad48468f82053005031f3b5b5eca85323b019
Author: Ilya Kasnacheev <il...@...>
Date:   2018-04-26T13:40:27Z

    IGNITE-6528 Print warnings when actual data type not equal to expected Indexed Type.

----


> Warning if no table for BinaryObject
> ------------------------------------
>
>                 Key: IGNITE-6528
>                 URL: https://issues.apache.org/jira/browse/IGNITE-6528
>             Project: Ignite
>          Issue Type: Improvement
>          Components: binary, cache, sql
>            Reporter: Mikhail Cherkasov
>            Assignee: Ilya Kasnacheev
>            Priority: Major
>
> I've seen several times that due wrong cache configuration people can't find 
> data in cache and blame Ignite that it's buggy and doesn't work.
> And it's very difficult to find an error in the code, especially if you don't have reach experience with Ignite.
> The problem is that we don't have strong typing when defining QueryEntriy and a user can use an arbitrary string id to
> define a type, but he should use the same string id to obtain binary object builder, however, people sometimes confusing this.
> So the user can define QueryEntity with value type:  queryEntity.setValueType("MyCoolName") and 
> later put to cache the following binary object: ignite.binary.toBinary(value), but this object won't be indexed, because
> ignite.binary.toBinary uses class name as string id while indexing expects to find "MyCoolName" as id.
> The example is simple and the error is obvious when you see this two lines close to each other, however, in real life, cache definition and data ingestion are separated by tons of code.
> We can save a lot of man-hours for our users if Ignite will print a warning If a cache has a configured QE and user puts BinaryObject with typeName which doesn't correspond to any QE.
> The warning should be printed only once, something like:
> [WARN] No table is found for %typeName% binary object.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)