You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2019/06/20 13:04:33 UTC

[GitHub] [maven-fluido-skin] michael-o commented on a change in pull request #10: Resolve XHTML5 compatibility issues highlighted by https://validator.…

michael-o commented on a change in pull request #10: Resolve XHTML5 compatibility issues highlighted by https://validator.…
URL: https://github.com/apache/maven-fluido-skin/pull/10#discussion_r295793514
 
 

 ##########
 File path: src/main/resources/META-INF/maven/site.vm
 ##########
 @@ -137,6 +137,11 @@
             </ul>
 #*      *##end
 ##
+#*      *##if (!$sideBarEnabled)
+          </nav>
+          <div class="nav-collapse">
 
 Review comment:
   I am confused about this. Why is this ecessary now and why not as `nav`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services