You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by "Aman-Mittal (via GitHub)" <gi...@apache.org> on 2025/08/15 18:34:23 UTC

[PR] FINERACT-2346: Minor sonarqube fixes [fineract]

Aman-Mittal opened a new pull request, #4959:
URL: https://github.com/apache/fineract/pull/4959

## Description

Fixes some of the identified code smells and maintainability issues.
Improves code readability and adherence to best practices.
Ensures no functional changes, focusing solely on code quality improvements.

Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).

## Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FINERACT-2346: Minor sonarqube fixes [fineract]

Posted by "Aman-Mittal (via GitHub)" <gi...@apache.org>.

Aman-Mittal commented on PR #4959:
URL: https://github.com/apache/fineract/pull/4959#issuecomment-3217100454

     
     > Task :integration-tests:test
     
     org.apache.fineract.integrationtests.LoanCatchUpIntegrationTest
     
       Test testCatchUpInLockedInstance() FAILED (14.1s)
     
       org.opentest4j.AssertionFailedError: expected: <2020-03-04> but was: <2020-03-02>
           at app//org.apache.fineract.integrationtests.LoanCatchUpIntegrationTest.testCatchUpInLockedInstance(LoanCatchUpIntegrationTest.java:128)
     
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FINERACT-2346: Minor sonarqube fixes [fineract]

Posted by "Aman-Mittal (via GitHub)" <gi...@apache.org>.

Aman-Mittal commented on PR #4959:
URL: https://github.com/apache/fineract/pull/4959#issuecomment-3195102206

   @galovics Pls re run the workflow, i have applied the spotless java changes and now giving successfull message on 
   
   BUILD SUCCESSFUL in 23m 3s
   670 actionable tasks: 585 executed, 17 from cache, 68 up-to-date
   10:22:59 am: Execution finished 'build -x test -x cucumber -x doc'.
   
   If there is any other test i have to run kindly tell me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FINERACT-2346: Minor sonarqube fixes [fineract]

Posted by "Aman-Mittal (via GitHub)" <gi...@apache.org>.

Aman-Mittal closed pull request #4959: FINERACT-2346: Minor sonarqube fixes
URL: https://github.com/apache/fineract/pull/4959


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FINERACT-2346: Minor sonarqube fixes [fineract]

Posted by "Aman-Mittal (via GitHub)" <gi...@apache.org>.

Aman-Mittal commented on PR #4959:
URL: https://github.com/apache/fineract/pull/4959#issuecomment-3218054322

   @galovics Please re run the workflow, Now all workflow should work.
   Ran workflow in my forked repository
   https://github.com/Aman-Mittal/fineract/commit/7b0b563d6b8209d624bffcc1fad7db3060974c06


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FINERACT-2346: Minor sonarqube fixes [fineract]

Posted by "Aman-Mittal (via GitHub)" <gi...@apache.org>.

Aman-Mittal commented on PR #4959:
URL: https://github.com/apache/fineract/pull/4959#issuecomment-3218105654

   rerasising pr with sqash commit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FINERACT-2346: Minor sonarqube fixes [fineract]

Posted by "Aman-Mittal (via GitHub)" <gi...@apache.org>.

Aman-Mittal commented on PR #4959:
URL: https://github.com/apache/fineract/pull/4959#issuecomment-3204200510

   @galovics Please re run workflow


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FINERACT-2346: Minor sonarqube fixes [fineract]

Posted by "Aman-Mittal (via GitHub)" <gi...@apache.org>.

Aman-Mittal commented on PR #4959:
URL: https://github.com/apache/fineract/pull/4959#issuecomment-3216838187

   @galovics Requesting you to review again as i have made more changes in files, And i noticed that in workflow rerun it was cancelled midway if any test is failing from my code please tell me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org