You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/21 15:29:34 UTC
[GitHub] [superset] geido opened a new pull request #15821: fix(Explore): Cell height and spacing for Data panel
geido opened a new pull request #15821:
URL: https://github.com/apache/superset/pull/15821
### SUMMARY
Makes the height of the cells consistent and improves spacing.
Fixes: #15691
### BEFORE
<img width="819" alt="125677475-ec7b35f4-5927-4181-9e2e-159895030ecf" src="https://user-images.githubusercontent.com/60598000/126515856-6fb5b6ad-4d1a-4b0b-ae41-2620cbfb8d1b.png">
<img width="818" alt="125676605-429bf2ec-d153-4be1-a8fc-48fd237fa546" src="https://user-images.githubusercontent.com/60598000/126515859-8e4613b4-c989-43d0-8255-4f7abeb64202.png">
### AFTER
<img width="1067" alt="Screen Shot 2021-07-21 at 17 25 22" src="https://user-images.githubusercontent.com/60598000/126515936-fd1e8c8a-1a93-40eb-8e51-b1093fc37ba4.png">
<img width="1055" alt="Screen Shot 2021-07-21 at 17 25 30" src="https://user-images.githubusercontent.com/60598000/126515947-29a7e605-0dd0-4180-830e-8ee57d5f56e2.png">
### TESTING INSTRUCTIONS
1. Open a Table chart in Explore
2. Observe the layout of the Data panel and spacing
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #15691
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #15821: fix(Explore): Cell height and spacing for Data panel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15821:
URL: https://github.com/apache/superset/pull/15821#issuecomment-884432657
@junlincc Ephemeral environment spinning up at http://34.217.84.207:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #15821: fix(Explore): Cell height and spacing for Data panel
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #15821:
URL: https://github.com/apache/superset/pull/15821#issuecomment-884430487
@geido Thank you for the PR! Diego, the purpose of the change is 1) visual consistency for all tables, 2) show more rows in the south table. Is there a particular reason why we are only showing 4 rows per page now after the spacing is decrease?
original comment
Issue 1: decrease spacing in the south table(view result, view sample) to be the same as table chart. the goal is to show more results and example rows, and for visual consistency. Please also check Pivot table v2 spacing
Issue 2: add spacing between tab and error msg. - cosmetic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #15821: fix(Explore): Cell height and spacing for Data panel
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #15821:
URL: https://github.com/apache/superset/pull/15821#issuecomment-884892603
Nice! Thanks for the improvement ❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #15821: fix(Explore): Cell height and spacing for Data panel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15821:
URL: https://github.com/apache/superset/pull/15821#issuecomment-884513633
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #15821: fix(Explore): Cell height and spacing for Data panel
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #15821:
URL: https://github.com/apache/superset/pull/15821#issuecomment-884431020
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #15821: fix(Explore): Cell height and spacing for Data panel
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #15821:
URL: https://github.com/apache/superset/pull/15821#issuecomment-884452421
@junlincc the PR only makes the table style in the data panel consistent with the table chart. The number of the shown items depends on the screen size. The screenshot was taken on a 15' screen. Probably the screenshot in the original issue was taken with a larger screen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15821: fix(Explore): Cell height and spacing for Data panel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #15821:
URL: https://github.com/apache/superset/pull/15821#issuecomment-884300929
# [Codecov](https://codecov.io/gh/apache/superset/pull/15821?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15821](https://codecov.io/gh/apache/superset/pull/15821?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5cfabf2) into [master](https://codecov.io/gh/apache/superset/commit/6cb91ee142091ea0c81ae2dc3e26efab82ee800b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6cb91ee) will **increase** coverage by `0.00%`.
> The diff coverage is `90.47%`.
> :exclamation: Current head 5cfabf2 differs from pull request most recent head 1a7d899. Consider uploading reports for the commit 1a7d899 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/15821?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15821 +/- ##
=======================================
Coverage 77.05% 77.06%
=======================================
Files 984 984
Lines 51650 51669 +19
Branches 6991 6995 +4
=======================================
+ Hits 39801 39819 +18
- Misses 11625 11626 +1
Partials 224 224
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.81% <77.77%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/15821?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/15821/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `84.26% <75.00%> (+0.36%)` | :arrow_up: |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/15821/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `95.77% <80.00%> (-1.20%)` | :arrow_down: |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/superset/pull/15821/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.93% <100.00%> (+0.11%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15821/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.55% <100.00%> (+0.08%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15821?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15821?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6cb91ee...1a7d899](https://codecov.io/gh/apache/superset/pull/15821?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido edited a comment on pull request #15821: fix(Explore): Cell height and spacing for Data panel
Posted by GitBox <gi...@apache.org>.
geido edited a comment on pull request #15821:
URL: https://github.com/apache/superset/pull/15821#issuecomment-884506986
P.S. I have closed the downloads in my browser which were occupying some space and I am seeing 5 items on my 15' laptop now.
<img width="1067" alt="Screen Shot 2021-07-21 at 17 25 22" src="https://user-images.githubusercontent.com/60598000/126560726-7f2fe77a-1208-4858-9b22-b9aa52cf648c.png">
If we want to show more rows we might need to act also on the height of the datapanel itself as reducing the height of the cells does not give that much additional space.
I would also like to point out that there are several other visual differences between the two tables. On the table chart, in every other row, the cells have a different background color. Also, the pagination is right positioned and comes in different colors compared to the table in the datapanel one.
Finally, the table of the datapanel is used in other places too, such as the "Change dataset" modal. I left that one untouched as the issue did not specify to change it everywhere.
If we are looking to make the tables look consistent (aka the same) everywhere, we have to change several other layout parts.
CC @junlincc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #15821: fix(Explore): Cell height and spacing for Data panel
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #15821:
URL: https://github.com/apache/superset/pull/15821#issuecomment-884300929
# [Codecov](https://codecov.io/gh/apache/superset/pull/15821?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15821](https://codecov.io/gh/apache/superset/pull/15821?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dc83d50) into [master](https://codecov.io/gh/apache/superset/commit/6cb91ee142091ea0c81ae2dc3e26efab82ee800b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6cb91ee) will **increase** coverage by `0.00%`.
> The diff coverage is `86.36%`.
> :exclamation: Current head dc83d50 differs from pull request most recent head 1a7d899. Consider uploading reports for the commit 1a7d899 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/15821?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15821 +/- ##
=======================================
Coverage 77.05% 77.06%
=======================================
Files 984 984
Lines 51650 51670 +20
Branches 6991 6996 +5
=======================================
+ Hits 39801 39819 +18
- Misses 11625 11627 +2
Partials 224 224
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.81% <70.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/15821?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/15821/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `94.44% <66.66%> (-2.53%)` | :arrow_down: |
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/15821/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `84.26% <75.00%> (+0.36%)` | :arrow_up: |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/superset/pull/15821/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.93% <100.00%> (+0.11%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15821/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.55% <100.00%> (+0.08%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15821?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15821?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6cb91ee...1a7d899](https://codecov.io/gh/apache/superset/pull/15821?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido edited a comment on pull request #15821: fix(Explore): Cell height and spacing for Data panel
Posted by GitBox <gi...@apache.org>.
geido edited a comment on pull request #15821:
URL: https://github.com/apache/superset/pull/15821#issuecomment-884452421
@junlincc the PR only makes the table style in the data panel consistent with the table chart. The number of the shown items depends on the screen size. The screenshot after the PR was taken on a 15' screen. Probably the screenshot in the original issue (which I have re-attached to this PR as a reference) was taken with a larger screen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #15821: fix(Explore): Cell height and spacing for Data panel
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #15821:
URL: https://github.com/apache/superset/pull/15821#issuecomment-884506986
P.S. I have closed the downloads in my browser which were occupying some space and I am seeing 5 items on my 15' laptop now.
<img width="1067" alt="Screen Shot 2021-07-21 at 17 25 22" src="https://user-images.githubusercontent.com/60598000/126560726-7f2fe77a-1208-4858-9b22-b9aa52cf648c.png">
If we want to show more rows we might need to act also on the height of the datapanel itself as reducing the height of the cells does not give that much additional space.
I would also like to point out that there are several other visual differences between the two tables. On the table chart, in every other row, the cells have a different background color. Also, the pagination is right positioned and comes in different colors compared to the table in the datapanel one.
Finally, the table of the datapanel is used in other places too, such as the "Change dataset" modal. I left that one untouched as the issue did not specify to change it everywhere.
If we are looking to make the tables look consistent (i.e. the same) everywhere, we have to change several other layout parts.
CC @junlincc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #15821: fix(Explore): Cell height and spacing for Data panel
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #15821:
URL: https://github.com/apache/superset/pull/15821#issuecomment-884430487
@geido Thank you for the PR! Diego, the purpose of the change is 1) visual consistency for all tables, 2) show more rows in the south table. Is there a particular reason why we are only showing 4 rows per page now after the spacing is reduced?
original comment
Issue 1: decrease spacing in the south table(view result, view sample) to be the same as table chart. the goal is to show more results and example rows, and for visual consistency. Please also check Pivot table v2 spacing
Issue 2: add spacing between tab and error msg. - cosmetic
cc @kgabryje
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #15821: fix(Explore): Cell height and spacing for Data panel
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #15821:
URL: https://github.com/apache/superset/pull/15821#issuecomment-884509478
LGTM! Thanks so much for making Superset SLICK!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #15821: fix(Explore): Cell height and spacing for Data panel
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #15821:
URL: https://github.com/apache/superset/pull/15821#issuecomment-884282265
@rosemarie-chiu @jinghua-qa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson merged pull request #15821: fix(Explore): Cell height and spacing for Data panel
Posted by GitBox <gi...@apache.org>.
pkdotson merged pull request #15821:
URL: https://github.com/apache/superset/pull/15821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #15821: fix(Explore): Cell height and spacing for Data panel
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #15821:
URL: https://github.com/apache/superset/pull/15821#issuecomment-884430487
@geido Thank you for the PR! Diego, the purpose of the change is 1) visual consistency for all tables, 2) show more rows in the south table. Is there a particular reason why we are only showing 4 rows per page now after the spacing is reduced?
original comment
Issue 1: decrease spacing in the south table(view result, view sample) to be the same as table chart. the goal is to show more results and example rows, and for visual consistency. Please also check Pivot table v2 spacing
Issue 2: add spacing between tab and error msg. - cosmetic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org