You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2011/06/11 03:48:04 UTC
[jira] [Created] (HDFS-2066) Create a package and individual class
files for DataTransferProtocol
Create a package and individual class files for DataTransferProtocol
--------------------------------------------------------------------
Key: HDFS-2066
URL: https://issues.apache.org/jira/browse/HDFS-2066
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Tsz Wo (Nicholas), SZE
{{DataTransferProtocol}} contains quite a few classes. It is better to create a package and put the classes into individual files.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2066) Create a package and individual
class files for DataTransferProtocol
Posted by "XieXianshan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048523#comment-13048523 ]
XieXianshan commented on HDFS-2066:
-----------------------------------
A little question.
Why did this patch not contain the following java files?
- mapreduce/src/contrib/raid/src/java/org/apache/hadoop/raid/BlockFixer.java
- mapreduce/src/contrib/raid/src/java/org/apache/hadoop/hdfs/server/datanode/RaidBlockSender.java
The class DataTransferProtocol has also been imported in these files.
> Create a package and individual class files for DataTransferProtocol
> --------------------------------------------------------------------
>
> Key: HDFS-2066
> URL: https://issues.apache.org/jira/browse/HDFS-2066
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, hdfs client, name-node
> Affects Versions: 0.23.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.23.0
>
> Attachments: h2066_20110610.patch
>
>
> {{DataTransferProtocol}} contains quite a few classes. It is better to create a package and put the classes into individual files.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2066) Create a package and individual
class files for DataTransferProtocol
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051032#comment-13051032 ]
Hudson commented on HDFS-2066:
------------------------------
Integrated in Hadoop-Hdfs-trunk #699 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/699/])
> Create a package and individual class files for DataTransferProtocol
> --------------------------------------------------------------------
>
> Key: HDFS-2066
> URL: https://issues.apache.org/jira/browse/HDFS-2066
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, hdfs client, name-node
> Affects Versions: 0.23.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.23.0
>
> Attachments: h2066_20110610.patch
>
>
> {{DataTransferProtocol}} contains quite a few classes. It is better to create a package and put the classes into individual files.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2066) Create a package and individual
class files for DataTransferProtocol
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047968#comment-13047968 ]
Tsz Wo (Nicholas), SZE commented on HDFS-2066:
----------------------------------------------
For committing this, we should first svn mv DataTransferProtocol.java and DataTransferProtoUtil.java.
Let's wait for HDFS-2067.
> Create a package and individual class files for DataTransferProtocol
> --------------------------------------------------------------------
>
> Key: HDFS-2066
> URL: https://issues.apache.org/jira/browse/HDFS-2066
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, hdfs client, name-node
> Affects Versions: 0.23.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h2066_20110610.patch
>
>
> {{DataTransferProtocol}} contains quite a few classes. It is better to create a package and put the classes into individual files.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2066) Create a package and individual
class files for DataTransferProtocol
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050111#comment-13050111 ]
Hudson commented on HDFS-2066:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #746 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/746/])
> Create a package and individual class files for DataTransferProtocol
> --------------------------------------------------------------------
>
> Key: HDFS-2066
> URL: https://issues.apache.org/jira/browse/HDFS-2066
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, hdfs client, name-node
> Affects Versions: 0.23.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.23.0
>
> Attachments: h2066_20110610.patch
>
>
> {{DataTransferProtocol}} contains quite a few classes. It is better to create a package and put the classes into individual files.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HDFS-2066) Create a package and individual class
files for DataTransferProtocol
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE reassigned HDFS-2066:
--------------------------------------------
Assignee: Tsz Wo (Nicholas), SZE
> Create a package and individual class files for DataTransferProtocol
> --------------------------------------------------------------------
>
> Key: HDFS-2066
> URL: https://issues.apache.org/jira/browse/HDFS-2066
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, hdfs client
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
>
> {{DataTransferProtocol}} contains quite a few classes. It is better to create a package and put the classes into individual files.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2066) Create a package and individual
class files for DataTransferProtocol
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047832#comment-13047832 ]
Hadoop QA commented on HDFS-2066:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12482128/h2066_20110610.patch
against trunk revision 1134492.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 30 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.cli.TestHDFSCLI
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/772//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/772//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/772//console
This message is automatically generated.
> Create a package and individual class files for DataTransferProtocol
> --------------------------------------------------------------------
>
> Key: HDFS-2066
> URL: https://issues.apache.org/jira/browse/HDFS-2066
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, hdfs client, name-node
> Affects Versions: 0.23.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h2066_20110610.patch
>
>
> {{DataTransferProtocol}} contains quite a few classes. It is better to create a package and put the classes into individual files.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2066) Create a package and individual
class files for DataTransferProtocol
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047834#comment-13047834 ]
Todd Lipcon commented on HDFS-2066:
-----------------------------------
+1, looks good to me.
> Create a package and individual class files for DataTransferProtocol
> --------------------------------------------------------------------
>
> Key: HDFS-2066
> URL: https://issues.apache.org/jira/browse/HDFS-2066
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, hdfs client, name-node
> Affects Versions: 0.23.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h2066_20110610.patch
>
>
> {{DataTransferProtocol}} contains quite a few classes. It is better to create a package and put the classes into individual files.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2066) Create a package and individual class
files for DataTransferProtocol
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-2066:
-----------------------------------------
Attachment: h2066_20110610.patch
h2066_20110610.patch: created a package.
> Create a package and individual class files for DataTransferProtocol
> --------------------------------------------------------------------
>
> Key: HDFS-2066
> URL: https://issues.apache.org/jira/browse/HDFS-2066
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, hdfs client
> Affects Versions: 0.23.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h2066_20110610.patch
>
>
> {{DataTransferProtocol}} contains quite a few classes. It is better to create a package and put the classes into individual files.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2066) Create a package and individual
class files for DataTransferProtocol
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048806#comment-13048806 ]
Tsz Wo (Nicholas), SZE commented on HDFS-2066:
----------------------------------------------
Hi Xie, thanks for pointing it out. It was fixed by MAPREDUCE-2588 earlier today.
> Create a package and individual class files for DataTransferProtocol
> --------------------------------------------------------------------
>
> Key: HDFS-2066
> URL: https://issues.apache.org/jira/browse/HDFS-2066
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, hdfs client, name-node
> Affects Versions: 0.23.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.23.0
>
> Attachments: h2066_20110610.patch
>
>
> {{DataTransferProtocol}} contains quite a few classes. It is better to create a package and put the classes into individual files.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2066) Create a package and individual class
files for DataTransferProtocol
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-2066:
-----------------------------------------
Resolution: Fixed
Fix Version/s: 0.23.0
Hadoop Flags: [Incompatible change, Reviewed] (was: [Incompatible change])
Status: Resolved (was: Patch Available)
Thanks Todd for the review.
I have committed this.
> Create a package and individual class files for DataTransferProtocol
> --------------------------------------------------------------------
>
> Key: HDFS-2066
> URL: https://issues.apache.org/jira/browse/HDFS-2066
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, hdfs client, name-node
> Affects Versions: 0.23.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.23.0
>
> Attachments: h2066_20110610.patch
>
>
> {{DataTransferProtocol}} contains quite a few classes. It is better to create a package and put the classes into individual files.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2066) Create a package and individual class
files for DataTransferProtocol
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-2066:
-----------------------------------------
Affects Version/s: 0.23.0
Hadoop Flags: [Incompatible change]
Status: Patch Available (was: Open)
> Create a package and individual class files for DataTransferProtocol
> --------------------------------------------------------------------
>
> Key: HDFS-2066
> URL: https://issues.apache.org/jira/browse/HDFS-2066
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, hdfs client
> Affects Versions: 0.23.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h2066_20110610.patch
>
>
> {{DataTransferProtocol}} contains quite a few classes. It is better to create a package and put the classes into individual files.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2066) Create a package and individual class
files for DataTransferProtocol
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-2066:
-----------------------------------------
Component/s: name-node
> Create a package and individual class files for DataTransferProtocol
> --------------------------------------------------------------------
>
> Key: HDFS-2066
> URL: https://issues.apache.org/jira/browse/HDFS-2066
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, hdfs client, name-node
> Affects Versions: 0.23.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h2066_20110610.patch
>
>
> {{DataTransferProtocol}} contains quite a few classes. It is better to create a package and put the classes into individual files.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira