[jira] [Commented] (YETUS-660) checkstyle should report when it fails to execute

["Allen Wittenauer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YETUS-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584377#comment-16584377 ] 

Allen Wittenauer commented on YETUS-660:
----------------------------------------

There is a lot going wrong here.  Let me attempt a summary.

hadoop-build-tools contains the checkstyle suppressions file as part of a resource that sits inside the generated jar.  That's important because when checkstyle runs, it pulls the suppressions file from the jar and specifically from the jar that is sitting in the maven repo cache.  So if a patch comes in that updates the suppression file, it MUST be installed into the maven repo cache in order to take effect.  

There are lots of consequences for that design.  The big one for Apache Yetus is that running something like "--plugins=checkstyle" will not work since mvn install won't get run to pop the new jar into place.

The other problem here is that the logic for failure in checkstyle. sh doesn't take into consideration if the actual command fails and instead checks the sed/grep pipe thing.  

> checkstyle should report when it fails to execute
> -------------------------------------------------
>
>                 Key: YETUS-660
>                 URL: https://issues.apache.org/jira/browse/YETUS-660
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Major
>             Fix For: 0.8.0
>
>
> As shown in HDDS-119/HADOOP-15675, the checkstyle plug-in fails to determine if it didn't actually run. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)