You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/08/13 00:03:57 UTC

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15868: fixing problem with existing Singleton Caching

larroy commented on a change in pull request #15868: fixing problem with existing Singleton Caching
URL: https://github.com/apache/incubator-mxnet/pull/15868#discussion_r313176642
 
 

 ##########
 File path: python/mxnet/runtime.py
 ##########
 @@ -77,11 +77,9 @@ class Features(collections.OrderedDict):
     def __new__(cls):
         if cls.instance is None:
             cls.instance = super(Features, cls).__new__(cls)
+            super(Features, cls.instance).__init__([(f.name, f) for f in feature_list()])
         return cls.instance
 
-    def __init__(self):
 
 Review comment:
   can you leave __init__ with "pass" or needs to be removed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services