You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/03/28 23:06:15 UTC
Review Request: Added EXPECT_DISPATCH.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10178/
-----------------------------------------------------------
Review request for mesos, Vinod Kone and Ben Mahler.
Description
-------
See summary.
Diffs
-----
third_party/libprocess/include/process/delay.hpp 44a5638fb8540cf67f6e586db4ed64c12129bf1c
third_party/libprocess/include/process/dispatch.hpp c6842b1a67a5326752bf300e427af5754800b6fd
third_party/libprocess/include/process/event.hpp a8ca8e085e83a7815cf27f908f58d5b263ce0f4e
third_party/libprocess/include/process/gmock.hpp PRE-CREATION
third_party/libprocess/src/process.cpp 9eb1962222c81675f105142c496ed64575ed4636
third_party/libprocess/src/tests/process_tests.cpp 2dd139489ba42103b2320e9a51154340644c5e9c
Diff: https://reviews.apache.org/r/10178/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Added EXPECT_DISPATCH.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10178/#review18488
-----------------------------------------------------------
Ship it!
sweet. but this means we need access to the receiver pid? or can we match on any pid if we know the method type?
- Vinod Kone
On March 28, 2013, 10:06 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10178/
> -----------------------------------------------------------
>
> (Updated March 28, 2013, 10:06 p.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> third_party/libprocess/include/process/delay.hpp 44a5638fb8540cf67f6e586db4ed64c12129bf1c
> third_party/libprocess/include/process/dispatch.hpp c6842b1a67a5326752bf300e427af5754800b6fd
> third_party/libprocess/include/process/event.hpp a8ca8e085e83a7815cf27f908f58d5b263ce0f4e
> third_party/libprocess/include/process/gmock.hpp PRE-CREATION
> third_party/libprocess/src/process.cpp 9eb1962222c81675f105142c496ed64575ed4636
> third_party/libprocess/src/tests/process_tests.cpp 2dd139489ba42103b2320e9a51154340644c5e9c
>
> Diff: https://reviews.apache.org/r/10178/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Added EXPECT_DISPATCH.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10178/#review18527
-----------------------------------------------------------
Ship it!
third_party/libprocess/include/process/gmock.hpp
<https://reviews.apache.org/r/10178/#comment38834>
Not that the original comment was useful, but it would be nice to document these for users of libprocess.
third_party/libprocess/include/process/gmock.hpp
<https://reviews.apache.org/r/10178/#comment38835>
ditto
- Ben Mahler
On March 28, 2013, 10:06 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10178/
> -----------------------------------------------------------
>
> (Updated March 28, 2013, 10:06 p.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> third_party/libprocess/include/process/delay.hpp 44a5638fb8540cf67f6e586db4ed64c12129bf1c
> third_party/libprocess/include/process/dispatch.hpp c6842b1a67a5326752bf300e427af5754800b6fd
> third_party/libprocess/include/process/event.hpp a8ca8e085e83a7815cf27f908f58d5b263ce0f4e
> third_party/libprocess/include/process/gmock.hpp PRE-CREATION
> third_party/libprocess/src/process.cpp 9eb1962222c81675f105142c496ed64575ed4636
> third_party/libprocess/src/tests/process_tests.cpp 2dd139489ba42103b2320e9a51154340644c5e9c
>
> Diff: https://reviews.apache.org/r/10178/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>