You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/06/08 02:46:38 UTC
[GitHub] [arrow] kou opened a new issue, #35987: [C++] Add support for Protobuf 23.2.0 on non-Windows
kou opened a new issue, #35987:
URL: https://github.com/apache/arrow/issues/35987
### Describe the enhancement requested
We can't resolve `google::protobuf::internal::ThreadSafeArena::thread_cache_` with Protobuf 23.2.0 on non-Windows:
```text
/Applications/Xcode_14.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../release/libarrow.a(util_avx2.cc.o) has no symbols
ld: illegal thread local variable reference to regular symbol __ZN6google8protobuf8internal15ThreadSafeArena13thread_cache_E for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
```
I think that https://github.com/protocolbuffers/protobuf/pull/12983 solves this but it's not released yet.
Workarounds:
1. Specify `PROTOBUF_USE_DLLS` explicitly on non-Windows too.
2. Use bundled (old) Protobuf
### Component(s)
C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on issue #35987: [C++] Add support for Protobuf 23.2 on non-Windows
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #35987:
URL: https://github.com/apache/arrow/issues/35987#issuecomment-1583336078
> Maybe a system version is also found and used?
I think so too. It looks like system Protobuf and bundled Protobuf are mixed. But it's strange... Our build process uses absolute path for `protoc`:
https://github.com/ursacomputing/crossbow/actions/runs/5210265087/jobs/9401119933#step:4:322
> ```text
> -- Found protoc: /var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/protobuf_ep-install/bin/protoc
> ```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on issue #35987: [C++] Add support for Protobuf 23.2.0 on non-Windows
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #35987:
URL: https://github.com/apache/arrow/issues/35987#issuecomment-1581851920
https://github.com/protocolbuffers/protobuf/issues/12699 is also related.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on issue #35987: [C++] Add support for Protobuf 23.2 on non-Windows
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on issue #35987:
URL: https://github.com/apache/arrow/issues/35987#issuecomment-1592695638
> @kou @js8544 from my understanding this fix on homebrew should allow us to unpin the versions of protobuf and grpc, right? [Homebrew/homebrew-core#133623](https://github.com/Homebrew/homebrew-core/pull/133623)
It probably does! I'll open a PR to try this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed issue #35987: [C++] Add support for Protobuf 23.2 on non-Windows
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou closed issue #35987: [C++] Add support for Protobuf 23.2 on non-Windows
URL: https://github.com/apache/arrow/issues/35987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on issue #35987: [C++] Add support for Protobuf 23.2 on non-Windows
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #35987:
URL: https://github.com/apache/arrow/issues/35987#issuecomment-1585802822
Oh, I didn't notice it!
It's not a real fix but it'll work as a workaround for now.
Could you open a pull request for the workaround?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on issue #35987: [C++] Add support for Protobuf 23.2 on non-Windows
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #35987:
URL: https://github.com/apache/arrow/issues/35987#issuecomment-1582053524
> I opened a very similar issue just ahead of you: #35986 ;-)
I saw it but I think that it's a different problem. :-)
> we set `PROTOBUF_USE_DLLS` also on unix to solve this.
I think that it's one of workarounds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on issue #35987: [C++] Add support for Protobuf 23.2 on non-Windows
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #35987:
URL: https://github.com/apache/arrow/issues/35987#issuecomment-1586333335
Reopen this because #36029 is a workaround.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on issue #35987: [C++] Add support for Protobuf 23.2 on non-Windows
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #35987:
URL: https://github.com/apache/arrow/issues/35987#issuecomment-1594199734
We don't need something because the problem was happen in upstream and it was fixed in upstream.
(We may want to reject Protobuf versions that have this problem explicitly.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] h-vetinari commented on issue #35987: [C++] Add support for Protobuf 23.2 on non-Windows
Posted by "h-vetinari (via GitHub)" <gi...@apache.org>.
h-vetinari commented on issue #35987:
URL: https://github.com/apache/arrow/issues/35987#issuecomment-1581857392
I opened a very similar issue just ahead of you: #35986 ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on issue #35987: [C++] Add support for Protobuf 23.2 on non-Windows
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on issue #35987:
URL: https://github.com/apache/arrow/issues/35987#issuecomment-1582561564
The error above is weird as that file is created in the cmake using protoc https://github.com/apache/arrow/blob/main/cpp/src/arrow/flight/CMakeLists.txt#L80
Maybe a system version is also found and used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on issue #35987: [C++] Add support for Protobuf 23.2 on non-Windows
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #35987:
URL: https://github.com/apache/arrow/issues/35987#issuecomment-1583718278
I think that `-DgRPC_SOURCE=BUNDLED` is needless because we always use the same `_SOURCE` for Protobuf and gRPC:
https://github.com/apache/arrow/blob/0bbfe98386edba436b7ff42dbde4853d289808ac/cpp/cmake_modules/ThirdpartyToolchain.cmake#L4080-L4084
> And remove them from the Brewfile
I think that this is needed. (Or we run `brew uninstall protobuf abseil grpc`.)
FYI: We can specify `-DProtobuf_SOURCE=BUNDLED` without changing our verification script by `ARROW_CMAKE_OPTIONS="-DProtobuf_SOURCE=BUNDLED` dev/release/verify-release-candidate.sh ...`.
> So probably not a blocker for the 12.0.1 release?
I think that this is not a blocker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on issue #35987: [C++] Add support for Protobuf 23.2 on non-Windows
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on issue #35987:
URL: https://github.com/apache/arrow/issues/35987#issuecomment-1585678831
> Homebrew is only effected for now. So I think that we can choose "2. Use bundled (old) Protobuf" (`-DProtobuf_SOURCE=BUNDLED`) and it's not a 12.0.1 release blocker.
> Homebrew is only effected for now. So I think that we can choose "2. Use bundled (old) Protobuf" (`-DProtobuf_SOURCE=BUNDLED`) and it's not a 12.0.1 release blocker.
Hi @kou, since only Homebrew is affected. Why not simply change protobuf to protobuf@21 in our brewfile?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on issue #35987: [C++] Add support for Protobuf 23.2 on non-Windows
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on issue #35987:
URL: https://github.com/apache/arrow/issues/35987#issuecomment-1582368275
> Homebrew is only effected for now. So I think that we can choose "2. Use bundled (old) Protobuf" (`-DProtobuf_SOURCE=BUNDLED`) and it's not a 12.0.1 release blocker.
I am trying to run the verification tasks for MacOS from my fork:
```
archery crossbow submit --job-prefix release-12.0.1-rc1-with-bundled-protobuf --arrow-branch release-12.0.1-rc1-with-bundled-protobuf --arrow-remote "https://github.com/raulcd/arrow" --arrow-version 12.0.1 verify-rc-source-*macos-*
```
Adding the following patch on top of the `release-12.0.1-rc1` branch:
```
$ git log -1 -p
commit 6989adf5de211d72199a6a627ea302338a65eb06 (HEAD -> release-12.0.1-rc1-with-bundled-protobuf, origin/release-12.0.1-rc1-with-bundled-protobuf)
Author: Raúl Cumplido <ra...@gmail.com>
Date: Thu Jun 8 12:23:44 2023 +0200
Try bundled protobuf for verification on macOS
diff --git a/dev/release/verify-release-candidate.sh b/dev/release/verify-release-candidate.sh
index 12e6d9c..080ffa2 100755
--- a/dev/release/verify-release-candidate.sh
+++ b/dev/release/verify-release-candidate.sh
@@ -641,6 +641,7 @@ test_and_install_cpp() {
-DPARQUET_BUILD_EXAMPLES=ON \
-DPARQUET_BUILD_EXECUTABLES=ON \
-DPARQUET_REQUIRE_ENCRYPTION=ON \
+ -DProtobuf_SOURCE=BUNDLED \
${ARROW_CMAKE_OPTIONS:-} \
${ARROW_SOURCE_DIR}/cpp
export CMAKE_BUILD_PARALLEL_LEVEL=${CMAKE_BUILD_PARALLEL_LEVEL:-${NPROC}}
```
And I am getting some failures on protobuf:
```
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:17:2: error: This file was generated by an older version of protoc which is
#error This file was generated by an older version of protoc which is
^
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:18:2: error: incompatible with your Protocol Buffer headers. Please
#error incompatible with your Protocol Buffer headers. Please
^
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:19:2: error: regenerate this file with a newer version of protoc.
#error regenerate this file with a newer version of protoc.
^
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:147:30: error: no type named 'ConstStringParam' in namespace 'google::protobuf'
::PROTOBUF_NAMESPACE_ID::ConstStringParam name, FlightDescriptor_DescriptorType* value) {
~~~~~~~~~~~~~~~~~~~~~~~~~^
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:256:35: error: no type named 'StringPiece' in namespace 'google::protobuf'
static ::PROTOBUF_NAMESPACE_ID::StringPiece FullMessageName() {
~~~~~~~~~~~~~~~~~~~~~~~~~^
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:221:5: error: use of undeclared identifier 'GOOGLE_DCHECK'
GOOGLE_DCHECK(GetOwningArena() == other->GetOwningArena());
^
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:257:12: error: cannot initialize return object of type 'int' with an lvalue of type 'const char [39]'
return "arrow.flight.protocol.HandshakeRequest";
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:420:35: error: no type named 'StringPiece' in namespace 'google::protobuf'
static ::PROTOBUF_NAMESPACE_ID::StringPiece FullMessageName() {
~~~~~~~~~~~~~~~~~~~~~~~~~^
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:385:5: error: use of undeclared identifier 'GOOGLE_DCHECK'
GOOGLE_DCHECK(GetOwningArena() == other->GetOwningArena());
^
[ 38%] Building CXX object src/arrow/acero/CMakeFiles/arrow_acero_objlib.dir/accumulation_queue.cc.o
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:421:12: error: cannot initialize return object of type 'int' with an lvalue of type 'const char [40]'
return "arrow.flight.protocol.HandshakeResponse";
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:584:35: error: no type named 'StringPiece' in namespace 'google::protobuf'
static ::PROTOBUF_NAMESPACE_ID::StringPiece FullMessageName() {
~~~~~~~~~~~~~~~~~~~~~~~~~^
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:549:5: error: use of undeclared identifier 'GOOGLE_DCHECK'
GOOGLE_DCHECK(GetOwningArena() == other->GetOwningArena());
^
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:585:12: error: cannot initialize return object of type 'int' with an lvalue of type 'const char [32]'
return "arrow.flight.protocol.BasicAuth";
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:738:35: error: no type named 'StringPiece' in namespace 'google::protobuf'
static ::PROTOBUF_NAMESPACE_ID::StringPiece FullMessageName() {
~~~~~~~~~~~~~~~~~~~~~~~~~^
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:717:5: error: use of undeclared identifier 'GOOGLE_DCHECK'
GOOGLE_DCHECK(GetOwningArena() == other->GetOwningArena());
^
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:739:12: error: cannot initialize return object of type 'int' with an lvalue of type 'const char [28]'
return "arrow.flight.protocol.Empty";
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:871:35: error: no type named 'StringPiece' in namespace 'google::protobuf'
static ::PROTOBUF_NAMESPACE_ID::StringPiece FullMessageName() {
~~~~~~~~~~~~~~~~~~~~~~~~~^
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:836:5: error: use of undeclared identifier 'GOOGLE_DCHECK'
GOOGLE_DCHECK(GetOwningArena() == other->GetOwningArena());
^
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:872:12: error: cannot initialize return object of type 'int' with an lvalue of type 'const char [33]'
return "arrow.flight.protocol.ActionType";
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
fatal error: too many errors emitted, stopping now [-ferror-limit=]
```
Examples:
https://github.com/ursacomputing/crossbow/actions/runs/5210265087/jobs/9401119933
https://github.com/ursacomputing/crossbow/actions/runs/5210265256/jobs/9401120122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on issue #35987: [C++] Add support for Protobuf 23.2 on non-Windows
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on issue #35987:
URL: https://github.com/apache/arrow/issues/35987#issuecomment-1583456540
It seems ti was GRPC. It should work if we use:
```
-DProtobuf_SOURCE=BUNDLED \
-DgRPC_SOURCE=BUNDLED \
```
And remove them from the Brewfile as seen on this testing PR: https://github.com/apache/arrow/pull/35995
So probably not a blocker for the 12.0.1 release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed issue #35987: [C++] Add support for Protobuf 23.2 on non-Windows
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou closed issue #35987: [C++] Add support for Protobuf 23.2 on non-Windows
URL: https://github.com/apache/arrow/issues/35987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on issue #35987: [C++] Add support for Protobuf 23.2.0 on non-Windows
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #35987:
URL: https://github.com/apache/arrow/issues/35987#issuecomment-1581807451
Homebrew is only effected for now.
So I think that we can choose "2. Use bundled (old) Protobuf" (`-DProtobuf_SOURCE=BUNDLED`) and it's not a 12.0.1 release blocker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] h-vetinari commented on issue #35987: [C++] Add support for Protobuf 23.2 on non-Windows
Posted by "h-vetinari (via GitHub)" <gi...@apache.org>.
h-vetinari commented on issue #35987:
URL: https://github.com/apache/arrow/issues/35987#issuecomment-1581864432
> I think that [protocolbuffers/protobuf#12983](https://github.com/protocolbuffers/protobuf/pull/12983) solves this but it's not released yet.
I have a feeling that this might not be backported to the 23.x series because it's effectively an ABI break. Perhaps I'm wrong though. Anyway, in conda-forge, we set `PROTOBUF_USE_DLLS` also on unix to solve this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on issue #35987: [C++] Add support for Protobuf 23.2 on non-Windows
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on issue #35987:
URL: https://github.com/apache/arrow/issues/35987#issuecomment-1592692095
@kou @js8544 from my understanding this fix on homebrew should allow us to unpin the versions of protobuf and grpc, right?
https://github.com/Homebrew/homebrew-core/pull/133623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on issue #35987: [C++] Add support for Protobuf 23.2 on non-Windows
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on issue #35987:
URL: https://github.com/apache/arrow/issues/35987#issuecomment-1592731468
> @kou @js8544 from my understanding this fix on homebrew should allow us to unpin the versions of protobuf and grpc, right? [Homebrew/homebrew-core#133623](https://github.com/Homebrew/homebrew-core/pull/133623)
Well, #36013 is still causing errors: https://github.com/apache/arrow/actions/runs/5277136967/jobs/9544769123?pr=36087. I'll try again once #36016 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org