[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #698: Support source class & method in to-jul (LOG4J2-3282)

[GitBox <gi...@apache.org>]

carterkozak commented on a change in pull request #698:
URL: https://github.com/apache/logging-log4j2/pull/698#discussion_r785030436



##########
File path: log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/LazyLog4jLogRecord.java
##########
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache license, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the license for the specific language governing permissions and
+ * limitations under the license.
+ */
+package org.apache.logging.log4j.tojul;
+
+import java.util.logging.Level;
+import java.util.logging.LogRecord;
+import org.apache.logging.log4j.util.StackLocatorUtil;
+
+/**
+ * Extension of {@link java.util.logging.LogRecord} with lazy get source related methods based on Log4j's {@link StackLocatorUtil#calcLocation(String)}.
+ *
+ * @author <a href="http://www.vorburger.ch">Michael Vorburger.ch</a> for Google
+ */
+/* package-local */ final class LazyLog4jLogRecord extends LogRecord {
+
+    private static final long serialVersionUID = 6798134264543826471L;
+
+    // parent class LogRecord already has a needToInferCaller but it's private
+    private transient boolean stillNeedToInferCaller = true;
+
+    private final String fqcn;
+
+    LazyLog4jLogRecord(String fqcn, Level level, String msg) {
+        super(level, msg);
+        this.fqcn = fqcn;
+    }
+
+    @Override
+    public String getSourceClassName() {
+        if (stillNeedToInferCaller) {
+            inferCaller();
+        }
+        return super.getSourceClassName();
+    }
+
+    @Override
+    public String getSourceMethodName() {
+        if (stillNeedToInferCaller) {
+            inferCaller();
+        }
+        return super.getSourceMethodName();
+    }
+
+    private void inferCaller() {

Review comment:
       synchronized creates more work than it avoids! If a logrecord is passed to another thread it must either be wrapped to avoid searching for callsite data, or must be filled in prior to being passed (much like log4j createMemento)
   This matches `java.util.logging.LogRecord` semantics.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org