You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/09/29 03:54:47 UTC
[GitHub] [incubator-kvrocks] xumingbo opened a new issue, #929: missing 'return'
xumingbo opened a new issue, #929:
URL: https://github.com/apache/incubator-kvrocks/issues/929
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-kvrocks/issues) and found no similar issues.
### Version
Latest commit [73092dc](https://github.com/apache/incubator-kvrocks/commit/73092dc4a5e4f87411133efdcf10b393dd8f9ae9) on Aug 17
### Minimal reproduce step
in redis_metadata.cc
in rocksdb::Status ListMetadata::Decode(const std::string &bytes)
line 282
if (input.size() < 12) rocksdb::Status::InvalidArgument(kErrMetadataTooShort);
Should be:
if (input.size() < 12) **return** rocksdb::Status::InvalidArgument(kErrMetadataTooShort);
same error at line 287
### What did you expect to see?
if (input.size() < 12) **return** rocksdb::Status::InvalidArgument(kErrMetadataTooShort);
### What did you see instead?
if (input.size() < 12) rocksdb::Status::InvalidArgument(kErrMetadataTooShort);
### Anything Else?
same issue on line 282 and 287
### Are you willing to submit a PR?
- [ ] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] aleksraiden commented on issue #929: missing 'return'
Posted by GitBox <gi...@apache.org>.
aleksraiden commented on issue #929:
URL: https://github.com/apache/incubator-kvrocks/issues/929#issuecomment-1261865394
I try to fix this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] xumingbo commented on issue #929: Some `return` is missing in redis_metadata.cc
Posted by GitBox <gi...@apache.org>.
xumingbo commented on issue #929:
URL: https://github.com/apache/incubator-kvrocks/issues/929#issuecomment-1262635803
Also:at line 325 if (input.size() < 12) {
rocksdb::Status::InvalidArgument(kErrMetadataTooShort);
}
Regards,
Bo Xu
On Thursday, September 29, 2022 at 12:16:07 AM PDT, Aleks Lozovyuk ***@***.***> wrote:
I try to fix this
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun closed issue #929: Some `return` is missing in redis_metadata.cc
Posted by GitBox <gi...@apache.org>.
tisonkun closed issue #929: Some `return` is missing in redis_metadata.cc
URL: https://github.com/apache/incubator-kvrocks/issues/929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] torwig commented on issue #929: Some `return` is missing in redis_metadata.cc
Posted by GitBox <gi...@apache.org>.
torwig commented on issue #929:
URL: https://github.com/apache/incubator-kvrocks/issues/929#issuecomment-1262664248
@xumingbo Pull request also fixes line 325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on issue #929: missing 'return'
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on issue #929:
URL: https://github.com/apache/incubator-kvrocks/issues/929#issuecomment-1261729777
Good catch! Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org