You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cassandra.apache.org by Jacek Lewandowski <le...@gmail.com> on 2023/11/27 13:03:12 UTC
Include CASSANDRA-18464 in 5.0-beta1 (direct I/O support for commitlog write)
Hey,
I'd like to ask if we can include
https://issues.apache.org/jira/browse/CASSANDRA-18464 in the 5.0-beta1
release. This introduces the ability to write to the commitlog using direct
I/O and bringing some noticeable performance improvements when enabled
(disabled by default).
Since it introduces a change in the yaml config, it probably cannot be
delivered in RC or 5.0.x - hence my question.
The ticket has been reviewed and tested. It is basically in the
read-to-commit state.
thanks,
Jacek
Re: Include CASSANDRA-18464 in 5.0-beta1 (direct I/O support for commitlog write)
Posted by Jacek Lewandowski <le...@gmail.com>.
Should I assume it's an agreement?
- - -- --- ----- -------- -------------
Jacek Lewandowski
wt., 28 lis 2023 o 12:05 Mick Semb Wever <mc...@apache.org> napisał(a):
>
>
> So, assuming beta2, can it be merged to cassandra-5.0 now?
>>
>
>
> Yes from me.
> And I would interpret Brandon and Maxwell's statements as supporting too.
>
>
>
Re: Include CASSANDRA-18464 in 5.0-beta1 (direct I/O support for commitlog write)
Posted by Mick Semb Wever <mc...@apache.org>.
So, assuming beta2, can it be merged to cassandra-5.0 now?
>
Yes from me.
And I would interpret Brandon and Maxwell's statements as supporting too.
Re: Include CASSANDRA-18464 in 5.0-beta1 (direct I/O support for commitlog write)
Posted by Jacek Lewandowski <le...@gmail.com>.
So, assuming beta2, can it be merged to cassandra-5.0 now?
- - -- --- ----- -------- -------------
Jacek Lewandowski
pon., 27 lis 2023 o 16:02 Mick Semb Wever <mc...@apache.org> napisał(a):
>
> I don't want to veto the 5.0-beta1 release for this.
>
> I would rather cut and include it in the next: 5.0-beta2; release.
> Given it's an add-on and does not change default behaviour, I believe this
> would be ok – if we agree.
>
> I feel this would be a better use of our time. And would mean, yes commit
> to cassandra-5.0
>
>
>
>
> On Mon, 27 Nov 2023 at 14:04, Jacek Lewandowski <
> lewandowski.jacek@gmail.com> wrote:
>
>> Hey,
>>
>> I'd like to ask if we can include
>> https://issues.apache.org/jira/browse/CASSANDRA-18464 in the 5.0-beta1
>> release. This introduces the ability to write to the commitlog using direct
>> I/O and bringing some noticeable performance improvements when enabled
>> (disabled by default).
>>
>> Since it introduces a change in the yaml config, it probably cannot be
>> delivered in RC or 5.0.x - hence my question.
>>
>> The ticket has been reviewed and tested. It is basically in the
>> read-to-commit state.
>>
>> thanks,
>> Jacek
>>
>>
Re: Include CASSANDRA-18464 in 5.0-beta1 (direct I/O support for commitlog write)
Posted by Mick Semb Wever <mc...@apache.org>.
I don't want to veto the 5.0-beta1 release for this.
I would rather cut and include it in the next: 5.0-beta2; release.
Given it's an add-on and does not change default behaviour, I believe this
would be ok – if we agree.
I feel this would be a better use of our time. And would mean, yes commit
to cassandra-5.0
On Mon, 27 Nov 2023 at 14:04, Jacek Lewandowski <le...@gmail.com>
wrote:
> Hey,
>
> I'd like to ask if we can include
> https://issues.apache.org/jira/browse/CASSANDRA-18464 in the 5.0-beta1
> release. This introduces the ability to write to the commitlog using direct
> I/O and bringing some noticeable performance improvements when enabled
> (disabled by default).
>
> Since it introduces a change in the yaml config, it probably cannot be
> delivered in RC or 5.0.x - hence my question.
>
> The ticket has been reviewed and tested. It is basically in the
> read-to-commit state.
>
> thanks,
> Jacek
>
>
Re: Include CASSANDRA-18464 in 5.0-beta1 (direct I/O support for commitlog write)
Posted by guo Maxwell <cc...@gmail.com>.
+1 😁
Brandon Williams <dr...@gmail.com> 于2023年11月27日周一 22:25写道：
> As long as it's disabled by default that's an easy +1 from me.
>
> Kind Regards,
> Brandon
>
> On Mon, Nov 27, 2023 at 7:03 AM Jacek Lewandowski
> <le...@gmail.com> wrote:
> >
> > Hey,
> >
> > I'd like to ask if we can include
> https://issues.apache.org/jira/browse/CASSANDRA-18464 in the 5.0-beta1
> release. This introduces the ability to write to the commitlog using direct
> I/O and bringing some noticeable performance improvements when enabled
> (disabled by default).
> >
> > Since it introduces a change in the yaml config, it probably cannot be
> delivered in RC or 5.0.x - hence my question.
> >
> > The ticket has been reviewed and tested. It is basically in the
> read-to-commit state.
> >
> > thanks,
> > Jacek
> >
>
Re: Include CASSANDRA-18464 in 5.0-beta1 (direct I/O support for commitlog write)
Posted by Brandon Williams <dr...@gmail.com>.
As long as it's disabled by default that's an easy +1 from me.
Kind Regards,
Brandon
On Mon, Nov 27, 2023 at 7:03 AM Jacek Lewandowski
<le...@gmail.com> wrote:
>
> Hey,
>
> I'd like to ask if we can include https://issues.apache.org/jira/browse/CASSANDRA-18464 in the 5.0-beta1 release. This introduces the ability to write to the commitlog using direct I/O and bringing some noticeable performance improvements when enabled (disabled by default).
>
> Since it introduces a change in the yaml config, it probably cannot be delivered in RC or 5.0.x - hence my question.
>
> The ticket has been reviewed and tested. It is basically in the read-to-commit state.
>
> thanks,
> Jacek
>