[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10729: Enhance the instrumentation for a corner case where the query doesn't go through DocIdSetOp

["siddharthteotia (via GitHub)" <gi...@apache.org>]

siddharthteotia commented on code in PR #10729:
URL: https://github.com/apache/pinot/pull/10729#discussion_r1188039034


##########
pinot-core/src/main/java/org/apache/pinot/core/operator/query/DictionaryBasedDistinctOperator.java:
##########
@@ -134,6 +128,20 @@ private DistinctTable buildResult() {
     return new DistinctTable(dataSchema, records, _nullHandlingEnabled);
   }
 
+  private void iterateOnDictionary(int dictLength, int actualLimit, List<Record> records, boolean isAscending) {
+    if (isAscending) {

Review Comment:
   (nit) I suggest separating this method into 2  to avoid doing the `if (_isAscending)` branch twice 
   
   cc @jasperjiaguo 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org