You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "yevgenypats (via GitHub)" <gi...@apache.org> on 2023/04/21 20:55:53 UTC

[GitHub] [arrow] yevgenypats commented on a diff in pull request #35257: GH-35156: [Go] Add ToMap to Metadata

yevgenypats commented on code in PR #35257:
URL: https://github.com/apache/arrow/pull/35257#discussion_r1174156926


##########
go/arrow/schema_test.go:
##########
@@ -99,6 +100,9 @@ func TestMetadata(t *testing.T) {
 			if got, want := tc.md.String(), tc.serialize; got != want {
 				t.Fatalf("invalid stringer: got=%q, want=%q", got, want)
 			}
+			if len(tc.kvs) != 0 {
+				assert.Equal(t, tc.kvs, md.ToMap())
+			}

Review Comment:
   I think we already have a round trip test here. We have `MetadataFrom` call on line 81



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org