You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zclllyybb (via GitHub)" <gi...@apache.org> on 2026/04/15 12:50:28 UTC

[PR] [improvement](ci) Enhance opencode review runner with stricter review requirements and higher model variant [doris]

zclllyybb opened a new pull request, #62528:
URL: https://github.com/apache/doris/pull/62528

   - Switch to "xhigh" model variant for more thorough analysis
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](ci) Enhance opencode review runner with stricter review requirements and higher model variant [doris]

Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #62528:
URL: https://github.com/apache/doris/pull/62528#issuecomment-4252159692

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](ci) Enhance opencode review runner with stricter review requirements and higher model variant [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62528:
URL: https://github.com/apache/doris/pull/62528#issuecomment-4252252832

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](ci) Enhance opencode review runner with stricter review requirements and higher model variant [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62528:
URL: https://github.com/apache/doris/pull/62528#issuecomment-4252321946

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](ci) Enhance opencode review runner with stricter review requirements and higher model variant [doris]

Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #62528:
URL: https://github.com/apache/doris/pull/62528#issuecomment-4252159829

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](ci) Enhance opencode review runner with stricter review requirements and higher model variant [doris]

Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb merged PR #62528:
URL: https://github.com/apache/doris/pull/62528


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](ci) Enhance opencode review runner with stricter review requirements and higher model variant [doris]

Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #62528:
URL: https://github.com/apache/doris/pull/62528#issuecomment-4252160125

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](ci) Enhance opencode review runner with stricter review requirements and higher model variant [doris]

Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #62528:
URL: https://github.com/apache/doris/pull/62528#issuecomment-4252201838

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](ci) Enhance opencode review runner with stricter review requirements and higher model variant [doris]

Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #62528:
URL: https://github.com/apache/doris/pull/62528#issuecomment-4252201303

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](ci) Enhance opencode review runner with stricter review requirements and higher model variant [doris]

Posted by "utafrali (via GitHub)" <gi...@apache.org>.
utafrali commented on code in PR #62528:
URL: https://github.com/apache/doris/pull/62528#discussion_r3086569954


##########
.github/workflows/opencode-review-runner.yml:
##########
@@ -90,6 +93,7 @@ jobs:
               - Build a JSON array of comments like: [{ "path": "<file>", "position": <diff_position>, "body": "..." }]
               - Submit via: gh api repos/PLACEHOLDER_REPO/pulls/PLACEHOLDER_PR_NUMBER/reviews --input <json_file>
               - The JSON file should contain: {"event":"REQUEST_CHANGES","body":"<summary>","comments":[...]}
+          - A complete and detailed review of the entire PR must be conducted, identifying all potential issues and submitting corresponding comments. Only then can the review work be considered finished. If this standard is not strictly met, the review of the remaining parts must continue.
           PROMPT

Review Comment:
   This added instruction -- "If this standard is not strictly met, the review of the remaining parts must continue" -- is ambiguous when given to a stateless LLM agent. The agent has no mechanism to loop back over work it has already submitted; the 55-minute job timeout is the only termination condition. In practice this line either has no effect, or it causes the agent to spend its remaining time generating redundant output instead of completing gracefully. Consider replacing it with a single, concrete completeness criterion such as "Every file changed in the diff must have at least one review comment or an explicit note that no issues were found."



##########
.github/workflows/opencode-review-runner.yml:
##########
@@ -111,7 +115,7 @@ jobs:
           PROMPT=$(cat /tmp/review_prompt.txt)

Review Comment:
   The `--variant "xhigh"` argument is placed after `2>&1`, which is a shell redirection. While bash technically strips redirections from the argument list and passes `--variant "xhigh"` to `opencode` correctly, this ordering is non-conventional and fragile -- some shells or future refactors could misinterpret it.
   
   Move `--variant` before the redirect:
   ```suggestion
             opencode run "$PROMPT" -m "github-copilot/gpt-5.4" --variant "xhigh" 2>&1 | tee /tmp/opencode-review.log
   ```



##########
.github/workflows/opencode-review-runner.yml:
##########
@@ -69,7 +69,10 @@ jobs:
       - name: Prepare review prompt
         run: |
           cat > /tmp/review_prompt.txt <<'PROMPT'
-          You are performing an automated code review inside a GitHub Actions runner. The gh CLI is available and authenticated via GH_TOKEN. You can comment on the pull request.
+          You are performing an automated code review inside a GitHub Actions runner. The gh CLI is available and authenticated via GH_TOKEN. 
+          The current directory is the code repository for the PR to be reviewed.

Review Comment:
   "Proceed with all subsequent research at the HIGHEST level of thought, aiming to identify all issues and submit all comments in JSON format" is vague. The phrase "HIGHEST level of thought" is not a defined instruction a model can act on. More concretely, asking to submit comments in JSON format here conflicts with the detailed GitHub Reviews API format described later in the prompt (which uses a specific object with `event`, `body`, and `comments` keys). This risks confusing the agent about the expected output format. Remove the JSON reference from this line to avoid the contradiction.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](ci) Enhance opencode review runner with stricter review requirements and higher model variant [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #62528:
URL: https://github.com/apache/doris/pull/62528#discussion_r3086596930


##########
.github/workflows/opencode-review-runner.yml:
##########
@@ -90,6 +93,7 @@ jobs:
               - Build a JSON array of comments like: [{ "path": "<file>", "position": <diff_position>, "body": "..." }]
               - Submit via: gh api repos/PLACEHOLDER_REPO/pulls/PLACEHOLDER_PR_NUMBER/reviews --input <json_file>
               - The JSON file should contain: {"event":"REQUEST_CHANGES","body":"<summary>","comments":[...]}
+          - A complete and detailed review of the entire PR must be conducted, identifying all potential issues and submitting corresponding comments. Only then can the review work be considered finished. If this standard is not strictly met, the review of the remaining parts must continue.
           PROMPT
           sed -i "s|PLACEHOLDER_REPO|${REPO}|g" /tmp/review_prompt.txt

Review Comment:
   This new requirement is not actually enforced by the workflow. The job still treats any zero-exit `opencode run` as success and never verifies that the agent really created a PR review/comment. If the model only prints a summary to stdout, this workflow still goes green, which defeats the purpose of tightening the review contract.
   
   Please add a post-run verification step that checks the PR for a newly created review/comment from this run and fails if none was submitted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org