[GitHub] [avro] zcsizmadia commented on a diff in pull request #2215: AVRO-3756: [csharp] Add a method to return types instead of writing them to disk

["zcsizmadia (via GitHub)" <gi...@apache.org>]

zcsizmadia commented on code in PR #2215:
URL: https://github.com/apache/avro/pull/2215#discussion_r1228470018


##########
lang/csharp/src/apache/main/CodeGen/CodeGen.cs:
##########
@@ -1136,6 +1136,48 @@
             }
         }
 
+        /// <summary>
+        /// Gets names and generated code of the schema(s) types
+        /// </summary>
+        /// <returns></returns>
+        public virtual IDictionary<string, string> GetTypes()
+        {
+            var cscp = new CSharpCodeProvider();

Review Comment:
   Please add  using to this just to avoid any potential resource leaks. Probably the other places should get the using as well (you mentioned that you followed the pattern of other code snippets)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org