[GitHub] [hudi] LinMingQiang commented on a diff in pull request #5884: [HUDI-3669] Add a remote request retry mechanism for 'Remotehoodietablefiles…

[GitBox <gi...@apache.org>]

LinMingQiang commented on code in PR #5884:
URL: https://github.com/apache/hudi/pull/5884#discussion_r899017812


##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/RemoteHoodieTableFileSystemView.java:
##########
@@ -165,16 +167,29 @@ private <T> T executeRequest(String requestPath, Map<String, String> queryParame
 
     String url = builder.toString();
     LOG.info("Sending request : (" + url + ")");
-    Response response;
+    Response response = null;
     int timeout = this.timeoutSecs * 1000; // msec
-    switch (method) {
-      case GET:
-        response = Request.Get(url).connectTimeout(timeout).socketTimeout(timeout).execute();
-        break;
-      case POST:
-      default:
-        response = Request.Post(url).connectTimeout(timeout).socketTimeout(timeout).execute();
+    int retryCounts = 0;
+    while (retryCounts <= maxRetries) {
+      try {
+        switch (method) {

Review Comment:
   Do we also need to add `retry.max_ interval_ ms`,`retry.initial_ interval_ ms` and `retry.exceptions` parameter?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org