You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Bud Bundy (JIRA)" <ji...@apache.org> on 2012/11/07 17:05:12 UTC

[jira] [Updated] (THRIFT-1748) Guard and RWGuard macros defined in global namespace

     [ https://issues.apache.org/jira/browse/THRIFT-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bud Bundy updated THRIFT-1748:
------------------------------

    Labels: newbie patch  (was: )
    
> Guard and RWGuard macros defined in global namespace
> ----------------------------------------------------
>
>                 Key: THRIFT-1748
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1748
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9
>         Environment: Visual Studio 2010
>            Reporter: Bud Bundy
>            Priority: Trivial
>              Labels: newbie, patch
>
> thrift/concurrency/Mutex.h defines global macros Guard and RWGuard.  Although the purpose is well commented and appreciated - i.e. trying to prevent coders from creating temporary variables and falsely assuming they have a lock - this code does interfere with other packages that define their own Guard classes.  Even when the user/library define Guard in their own namespace, there's a clash.
> Please remove the macros.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira