[jira] [Commented] (HBASE-15778) replace master.am and master.sm direct access with getter calls

["Stephen Yuan Jiang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-15778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274257#comment-15274257 ] 

Stephen Yuan Jiang commented on HBASE-15778:
--------------------------------------------

Looks good.

> replace master.am and master.sm direct access with getter calls
> ---------------------------------------------------------------
>
>                 Key: HBASE-15778
>                 URL: https://issues.apache.org/jira/browse/HBASE-15778
>             Project: HBase
>          Issue Type: Sub-task
>          Components: master
>    Affects Versions: 2.0.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Trivial
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15778-v0.patch
>
>
> MasterRpcServices seems to access directly a bunch of members of HMaster. I think this is because when we split HMaster and MaterRpcServices we just did a find & replace.
> I was trying to mock and have a different AssignmentManager and ServerManager but it got impossible with those access directly.
> so, here a patch to avoid the direct access to AM and SM.
> There are many more members that can be made private but I'm lazy. so this pass is only AM, SM related



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)