You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@logging.apache.org by dpsenner <gi...@git.apache.org> on 2017/06/22 21:02:53 UTC

[GitHub] logging-log4net pull request #9: Allow for dates that aren't necessarily in ...

GitHub user dpsenner opened a pull request:

    https://github.com/apache/logging-log4net/pull/9

    Allow for dates that aren't necessarily in the yyyy-MM-dd format.

    This reopens the old pull request 43. Please note that the old pull request 29 (reopened as #6) provides the same functionality.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/logging-log4net pr/old/43

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/logging-log4net/pull/9.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #9
    
----
commit 1a8eb94da4cf9b7b0f88140407486bd9defc901a
Author: Steven Nicholas <st...@snware.com>
Date:   2017-03-08T07:08:26Z

    Allow for dates that aren't necessarily in the yyyy-MM-dd format.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] logging-log4net issue #9: Allow for dates that aren't necessarily in the yyy...

Posted by dpsenner <gi...@git.apache.org>.
Github user dpsenner commented on the issue:

    https://github.com/apache/logging-log4net/pull/9
  
    With respect to #6 this patch is cleaner. Since this affects the current behavior and I have a bad feeling about changing the behavior of the rolling file appender, I see a unit test as a requirement for this pull request to proceed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---