You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "belliottsmith (via GitHub)" <gi...@apache.org> on 2025/06/24 16:16:41 UTC
[PR] Fixes 250622 [cassandra]
belliottsmith opened a new pull request, #4210:
URL: https://github.com/apache/cassandra/pull/4210
Thanks for sending a pull request! Here are some tips if you're new here:
* Ensure you have added or run the [appropriate tests](https://cassandra.apache.org/_/development/testing.html) for your PR.
* Be sure to keep the PR description updated to reflect all changes.
* Write your PR title to summarize what this PR proposes.
* If possible, provide a concise example to reproduce the issue for a faster review.
* Read our [contributor guidelines](https://cassandra.apache.org/_/development/index.html)
* If you're making a documentation change, see our [guide to documentation contribution](https://cassandra.apache.org/_/development/documentation.html)
Commit messages should follow the following format:
```
<One sentence description, usually Jira title or CHANGES.txt summary>
<Optional lengthier description (context on patch)>
patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####
Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>
```
The [Cassandra Jira](https://issues.apache.org/jira/projects/CASSANDRA/issues/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Fixes 250622 [cassandra]
Posted by "belliottsmith (via GitHub)" <gi...@apache.org>.
belliottsmith merged PR #4210:
URL: https://github.com/apache/cassandra/pull/4210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Fixes 250622 [cassandra]
Posted by "ifesdjeen (via GitHub)" <gi...@apache.org>.
ifesdjeen commented on code in PR #4210:
URL: https://github.com/apache/cassandra/pull/4210#discussion_r2164583358
##########
test/unit/org/apache/cassandra/utils/RangeTreeTest.java:
##########
@@ -363,39 +376,89 @@ private static Model create(ModelType modelType)
{
switch (modelType)
{
- case List:
case SearchableRangeList:
return new SearchableRangeListModel();
case RTree:
- return new RangeTreeModel(new RTree<>(COMPARATOR, ALL_INCLUSIVE));
+ return new RangeTreeModel();
case IntervalTree:
return new IntervalTreeModel();
case IntervalBTree:
- return new RangeTreeModel(new RTree<>(COMPARATOR, ALL_INCLUSIVE));
+ return new IntervalBTreeModel();
default:
throw new AssertionError("Unknown type: " + modelType);
}
}
- private static Model createModel(ModelType modelType)
+ private static Model createOracleForValidating(ModelType modelType)
{
- switch (modelType)
+// if (modelType == ModelType.IntervalTree)
Review Comment:
Nit: probably worth to clean this up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org