You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/05/22 21:18:15 UTC
Review Request 59466: Add metrics check to Fetcher tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59466/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Add metrics check to Fetcher tests.
Diffs
-----
src/tests/fetcher_tests.cpp 27ea7244c713934ef5a721ec133804a006dcb26e
Diff: https://reviews.apache.org/r/59466/diff/1/
Testing
-------
make check (Fedora 25)
Thanks,
James Peach
Re: Review Request 59466: Add metrics check to Fetcher tests.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59466/#review178546
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On June 9, 2017, 11:56 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59466/
> -----------------------------------------------------------
>
> (Updated June 9, 2017, 11:56 a.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-7524
> https://issues.apache.org/jira/browse/MESOS-7524
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For each fetcher test, verify that the count of fetches and the count
> of errors is what we expect.
>
>
> Diffs
> -----
>
> src/tests/fetcher_tests.cpp b4124158a0e92f289f0edc0c8cb9394350e1cbb5
>
>
> Diff: https://reviews.apache.org/r/59466/diff/4/
>
>
> Testing
> -------
>
> make check (Fedora 25)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 59466: Add metrics check to Fetcher tests.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59466/
-----------------------------------------------------------
(Updated June 9, 2017, 6:56 p.m.)
Review request for mesos and Joseph Wu.
Changes
-------
Rebased.
Bugs: MESOS-7524
https://issues.apache.org/jira/browse/MESOS-7524
Repository: mesos
Description
-------
For each fetcher test, verify that the count of fetches and the count
of errors is what we expect.
Diffs (updated)
-----
src/tests/fetcher_tests.cpp b4124158a0e92f289f0edc0c8cb9394350e1cbb5
Diff: https://reviews.apache.org/r/59466/diff/4/
Changes: https://reviews.apache.org/r/59466/diff/3-4/
Testing
-------
make check (Fedora 25)
Thanks,
James Peach
Re: Review Request 59466: Add metrics check to Fetcher tests.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59466/
-----------------------------------------------------------
(Updated June 6, 2017, 8:20 p.m.)
Review request for mesos and Mesos Reviewbot.
Bugs: MESOS-7524
https://issues.apache.org/jira/browse/MESOS-7524
Repository: mesos
Description
-------
For each fetcher test, verify that the count of fetches and the count
of errors is what we expect.
Diffs (updated)
-----
src/tests/fetcher_tests.cpp b4124158a0e92f289f0edc0c8cb9394350e1cbb5
Diff: https://reviews.apache.org/r/59466/diff/3/
Changes: https://reviews.apache.org/r/59466/diff/2-3/
Testing
-------
make check (Fedora 25)
Thanks,
James Peach
Re: Review Request 59466: Add metrics check to Fetcher tests.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59466/
-----------------------------------------------------------
(Updated May 22, 2017, 9:18 p.m.)
Review request for mesos and Mesos Reviewbot.
Bugs: MESOS-7524
https://issues.apache.org/jira/browse/MESOS-7524
Repository: mesos
Description
-------
Add metrics check to Fetcher tests.
Diffs
-----
src/tests/fetcher_tests.cpp 27ea7244c713934ef5a721ec133804a006dcb26e
Diff: https://reviews.apache.org/r/59466/diff/1/
Testing
-------
make check (Fedora 25)
Thanks,
James Peach