[GitHub] [iceberg] holdenk commented on a change in pull request #1613: Provide Actions class for Spark2 and Spark3

[GitBox <gi...@apache.org>]

holdenk commented on a change in pull request #1613:
URL: https://github.com/apache/iceberg/pull/1613#discussion_r504982211



##########
File path: spark/src/test/java/org/apache/iceberg/spark/SparkTestBase.java
##########
@@ -124,4 +126,8 @@ protected void assertEquals(String context, List<Object[]> expectedRows, List<Ob
   protected static String dbPath(String dbName) {
     return metastore.getDatabasePath(dbName);
   }
+
+  protected BaseActions actionsForTable(Table table) {
+    throw new UnsupportedOperationException("Reimplement actionsForTable with Actions.forTable() if needed");
+  }

Review comment:
       If this is only sometimes needed would it make sense to have this be a separate interface? (totally possible I've been writing too much scala code though and that pattern would be annoying to do here)/




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org