[GitHub] merlimat commented on a change in pull request #1279: PIP-13-2/3: support regex based subscription

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #1279: PIP-13-2/3: support regex based subscription
URL: https://github.com/apache/incubator-pulsar/pull/1279#discussion_r170433266
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/HttpLookupService.java
 ##########
 @@ -88,6 +92,29 @@ public String getServiceUrl() {
     	return httpClient.url.toString();
     }
 
+    @Override
+    public CompletableFuture<List<String>> getTopicsUnderNamespace(NamespaceName namespace) {
+        CompletableFuture<List<String>> future = new CompletableFuture<>();
+        httpClient
+            .get(String.format("admin/namespaces/%s/destinations", namespace), String[].class)
 
 Review comment:
   We should be able to deserialize directly into a `List<String>` with Jackson, by passing `List.class`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services