You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Hugo Trippaers <ht...@schubergphilis.com> on 2012/07/09 20:43:06 UTC
Review Request: This table should not have a contraint on device and
physical network id. This is dealt with in the code and by using the
removed field.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5839/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
While running some test scripts I noticed that the table 'physical_network_service_providers' has a unique key on the combination of physical_network_id and provider_name, this is potentially a problem when we also use the removed field to indicate a device is removed.
As Alex indicated this is a bug and here is a proposed fix.
Diffs
-----
setup/db/create-schema.sql c2efb27
Diff: https://reviews.apache.org/r/5839/diff/
Testing
-------
Removed the constraint and added a new device, works and a list devices shows only one device.
Thanks,
Hugo Trippaers
Re: Review Request: This table should not have a contraint on device and
physical network id. This is dealt with in the code and by using the
removed field.
Posted by Prachi Damle <pr...@citrix.com>.
> On July 24, 2012, 9:41 p.m., Prachi Damle wrote:
> > Fix is good. The code for addNetworkServiceProvider API makes sure only one provider of a given name exists on a physical network.
Can you please file this as a bug in Jira?
- Prachi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5839/#review9416
-----------------------------------------------------------
On July 9, 2012, 6:44 p.m., Hugo Trippaers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5839/
> -----------------------------------------------------------
>
> (Updated July 9, 2012, 6:44 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> While running some test scripts I noticed that the table 'physical_network_service_providers' has a unique key on the combination of physical_network_id and provider_name, this is potentially a problem when we also use the removed field to indicate a device is removed.
>
> As Alex indicated this is a bug and here is a proposed fix.
>
>
> Diffs
> -----
>
> setup/db/create-schema.sql c2efb27
>
> Diff: https://reviews.apache.org/r/5839/diff/
>
>
> Testing
> -------
>
> Removed the constraint and added a new device, works and a list devices shows only one device.
>
>
> Thanks,
>
> Hugo Trippaers
>
>
Re: Review Request: This table should not have a contraint on device and
physical network id. This is dealt with in the code and by using the
removed field.
Posted by Prachi Damle <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5839/#review9416
-----------------------------------------------------------
Ship it!
Fix is good. The code for addNetworkServiceProvider API makes sure only one provider of a given name exists on a physical network.
- Prachi Damle
On July 9, 2012, 6:44 p.m., Hugo Trippaers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5839/
> -----------------------------------------------------------
>
> (Updated July 9, 2012, 6:44 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> While running some test scripts I noticed that the table 'physical_network_service_providers' has a unique key on the combination of physical_network_id and provider_name, this is potentially a problem when we also use the removed field to indicate a device is removed.
>
> As Alex indicated this is a bug and here is a proposed fix.
>
>
> Diffs
> -----
>
> setup/db/create-schema.sql c2efb27
>
> Diff: https://reviews.apache.org/r/5839/diff/
>
>
> Testing
> -------
>
> Removed the constraint and added a new device, works and a list devices shows only one device.
>
>
> Thanks,
>
> Hugo Trippaers
>
>
RE: Review Request: This table should not have a contraint on
device and physical network id. This is dealt with in the code and by using
the removed field.
Posted by Hugo Trippaers <HT...@schubergphilis.com>.
Agreed,
I'll more than happy to put it in, but I don't know where exactly.
-----Original Message-----
From: Alena Prokharchyk [mailto:Alena.Prokharchyk@citrix.com]
Sent: Monday, July 09, 2012 8:48 PM
To: cloudstack-dev@incubator.apache.org; Hugo Trippaers
Subject: Re: Review Request: This table should not have a contraint on device and physical network id. This is dealt with in the code and by using the removed field.
DataBase upgrade part of the code should be fixed as well. For all existing customers this key has to be dropped as a part of the upgrade.
-Alena.
On 7/9/12 11:44 AM, "Hugo Trippaers" <ht...@schubergphilis.com> wrote:
>
>-----------------------------------------------------------
>This is an automatically generated e-mail. To reply, visit:
>https://reviews.apache.org/r/5839/
>-----------------------------------------------------------
>
>(Updated July 9, 2012, 6:44 p.m.)
>
>
>Review request for cloudstack.
>
>
>Description
>-------
>
>While running some test scripts I noticed that the table
>'physical_network_service_providers' has a unique key on the
>combination of physical_network_id and provider_name, this is
>potentially a problem when we also use the removed field to indicate a device is removed.
>
>As Alex indicated this is a bug and here is a proposed fix.
>
>
>Diffs
>-----
>
> setup/db/create-schema.sql c2efb27
>
>Diff: https://reviews.apache.org/r/5839/diff/
>
>
>Testing
>-------
>
>Removed the constraint and added a new device, works and a list devices
>shows only one device.
>
>
>Thanks,
>
>Hugo Trippaers
>
>
Re: Review Request: This table should not have a contraint on
device and physical network id. This is dealt with in the code and by using
the removed field.
Posted by Alena Prokharchyk <Al...@citrix.com>.
DataBase upgrade part of the code should be fixed as well. For all
existing customers this key has to be dropped as a part of the upgrade.
-Alena.
On 7/9/12 11:44 AM, "Hugo Trippaers" <ht...@schubergphilis.com> wrote:
>
>-----------------------------------------------------------
>This is an automatically generated e-mail. To reply, visit:
>https://reviews.apache.org/r/5839/
>-----------------------------------------------------------
>
>(Updated July 9, 2012, 6:44 p.m.)
>
>
>Review request for cloudstack.
>
>
>Description
>-------
>
>While running some test scripts I noticed that the table
>'physical_network_service_providers' has a unique key on the combination
>of physical_network_id and provider_name, this is potentially a problem
>when we also use the removed field to indicate a device is removed.
>
>As Alex indicated this is a bug and here is a proposed fix.
>
>
>Diffs
>-----
>
> setup/db/create-schema.sql c2efb27
>
>Diff: https://reviews.apache.org/r/5839/diff/
>
>
>Testing
>-------
>
>Removed the constraint and added a new device, works and a list devices
>shows only one device.
>
>
>Thanks,
>
>Hugo Trippaers
>
>
Re: Review Request: This table should not have a contraint on device and
physical network id. This is dealt with in the code and by using the
removed field.
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5839/
-----------------------------------------------------------
(Updated July 9, 2012, 6:44 p.m.)
Review request for cloudstack.
Description
-------
While running some test scripts I noticed that the table 'physical_network_service_providers' has a unique key on the combination of physical_network_id and provider_name, this is potentially a problem when we also use the removed field to indicate a device is removed.
As Alex indicated this is a bug and here is a proposed fix.
Diffs
-----
setup/db/create-schema.sql c2efb27
Diff: https://reviews.apache.org/r/5839/diff/
Testing
-------
Removed the constraint and added a new device, works and a list devices shows only one device.
Thanks,
Hugo Trippaers