[GitHub] ottobackwards commented on issue #3222: NIFI-5900 Added StreamingJsonReader.

[GitBox <gi...@apache.org>]

ottobackwards commented on issue #3222: NIFI-5900 Added StreamingJsonReader.
URL: https://github.com/apache/nifi/pull/3222#issuecomment-447888589
 
 
   So, the issue is the jsonPath, not the tree node reader.  As we have discussed in NIFI-3126.  I didn't do the POC on jsonSurfer because the work around seemed to be what we wanted at the time. 
   
   I think this is a good idea like, although it has to be clear what it's use case is.
   
   The first question I have after a quick glance is how much of this code for producing the record from json is common between our json readers?   If we have multiple readers with copies of the same json->record code, we should consolidate them into a single code path.
   
   Also, should the documentation of the existing readers be updated to point people with the use case in the right direction?
   
   Can you confirm which reader you had the issue with?  Was it the JsonPathReader?
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services