You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/06 07:13:49 UTC

[GitHub] [arrow] rymurr commented on a change in pull request #7100: ARROW-8696: [Java] Convert tests to maven failsafe

rymurr commented on a change in pull request #7100:
URL: https://github.com/apache/arrow/pull/7100#discussion_r420586995



##########
File path: java/memory/src/test/java/org/apache/arrow/memory/ITTestLargeArrowBuf.java
##########
@@ -27,38 +32,45 @@
  *   main method.
  * </p>
  */
-public class TestLargeArrowBuf {
+public class ITTestLargeArrowBuf {
+  private static final Logger logger = LoggerFactory.getLogger(ITTestLargeArrowBuf.class);

Review comment:
       logger is (in my experience anyways) an exception to the rule. Currently in arrow logger is used in 24 places and LOGGER in 15. I am happy with either way as long as we are consistent




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org