You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by heymartinadams <gi...@git.apache.org> on 2017/08/19 23:06:54 UTC

[GitHub] cordova-docs pull request #722: Update index.md

GitHub user heymartinadams opened a pull request:

    https://github.com/apache/cordova-docs/pull/722

    Update index.md

    Duplicate entry of `--`, or missing additional parameter, as the case may be.
    
    ### Platforms affected
    
    Docs
    
    ### What does this PR do?
    
    Correction
    
    ### What testing has been done on this change?
    
    Terminal on mac.
    
    ### Checklist
    **n/a**
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/heymartinadams/cordova-docs patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-docs/pull/722.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #722
    
----
commit 5a6b6ae1d11e6177251e3342cea1d1580cf538d4
Author: Martin Adams <he...@users.noreply.github.com>
Date:   2017-08-19T23:05:23Z

    Update index.md
    
    Duplicate entry of `--`, or missing additional parameter, as the case may be.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-docs issue #722: Update index.md

Posted by janpio <gi...@git.apache.org>.
Github user janpio commented on the issue:

    https://github.com/apache/cordova-docs/pull/722
  
    See the line above your edit:
    
    > You should use double `--` to indicate that these are platform-specific arguments, for example:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-docs issue #722: Update index.md

Posted by heymartinadams <gi...@git.apache.org>.
Github user heymartinadams commented on the issue:

    https://github.com/apache/cordova-docs/pull/722
  
    It wasn’t clear to me from the docs that the empty `--` also had a purpose. Terminal earlier threw an error with it, so I thought that was the cause, but somehow now it doesn’t.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-docs pull request #722: Update index.md

Posted by janpio <gi...@git.apache.org>.
Github user janpio commented on a diff in the pull request:

    https://github.com/apache/cordova-docs/pull/722#discussion_r134116008
  
    --- Diff: www/docs/en/6.x/guide/platforms/android/index.md ---
    @@ -310,7 +310,7 @@ To sign an app, you need the following parameters:
     These parameters can be specified using the command line arguments above to
     the [Cordova CLI][cli_reference] `build` or `run` commands.
     
    -__Note__: You should use double `--` to indicate that these are platform-specific arguments, for example:
    +__Note__: You should use double `--` (followed by a space) to indicate that these are platform-specific arguments, for example:
    --- End diff --
    
    maybe add an "i.e. `-- --`" in the brackets as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org