[GitHub] jlahoda commented on a change in pull request #401: [NETBEANS-317] (partial) Adding licenses and notice for files inside ���

[GitBox <gi...@apache.org>]

jlahoda commented on a change in pull request #401: [NETBEANS-317] (partial) Adding licenses and notice for files inside …
URL: https://github.com/apache/incubator-netbeans/pull/401#discussion_r176981579
 
 

 ##########
 File path: maven.embedder/external/apache-maven-3.3.9-bin-notice.txt
 ##########
 @@ -0,0 +1,186 @@
+Apache Maven Distribution
+Copyright 2001-2015 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
 
 Review comment:
   (Sorry for late reply.) Yes, that is not needed in the final NOTICE, and it won't be there - the task that merges notices strips there lines automatically. And it seems useful to keep manual edits to this file at minimum (this is actually concatenation of all NOTICEs from the whole Maven distro), to prevent mistakes.
   
   Ok to merge?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists