[GitHub] [pulsar] rdhabalia commented on a change in pull request #3819: [pulsar-broker] Cache unack-messageId into openRangeSet

[GitBox <gi...@apache.org>]

rdhabalia commented on a change in pull request #3819: [pulsar-broker] Cache unack-messageId into openRangeSet
URL: https://github.com/apache/pulsar/pull/3819#discussion_r285772419
 
 

 ##########
 File path: managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryTest.java
 ##########
 @@ -62,13 +65,13 @@ public void testGetManagedLedgerInfoWithClose() throws Exception {
         assertEquals(cursorInfo.markDelete.ledgerId, 3);
         assertEquals(cursorInfo.markDelete.entryId, -1);
 
-        assertEquals(cursorInfo.individualDeletedMessages.size(), 1);
+        assertEquals(cursorInfo.individualDeletedMessages.size(), 2);
 
 Review comment:
   Yes, `ConcurrentOpenLongPairRangeSet` has separate BitSet for every ledger and while creating ranges it doesn't merge range from different ledgers (doesn't merge last entry of previous ledger with first entry of next ledger) so, instead one combined ledger-range it returns multiple ranges when ledgers are different.
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services