[GitHub] [spark] juliuszsompolski commented on issue #25960: [SPARK-29283][SQL] Error message is hidden when query from JDBC, especially enabled adaptive execution

[GitBox <gi...@apache.org>]

juliuszsompolski commented on issue #25960: [SPARK-29283][SQL] Error message is hidden when query from JDBC, especially enabled adaptive execution
URL: https://github.com/apache/spark/pull/25960#issuecomment-536923555
 
 
   For consistency, should we do that in all Spark*Operation?
   I.e. replace the current
   ```
         case e: HiveSQLException =>
           setState(OperationState.ERROR)
           HiveThriftServer2.listener.onStatementError(
             statementId, e.getMessage, SparkUtils.exceptionString(e))
           throw e
   ```
   with 
   ```
     case e: Throwable =>
       logError(s"Error executing operation with $statementId, currentState $currentState, ", e)
       setState(OperationState.ERROR)
       HiveThriftServer2.listener.onStatementError(
         statementId, e.getMessage, SparkUtils.exceptionString(e))
       if (e.isInstanceOf[HiveSQLException]) {
         throw e.asInstanceOf[HiveSQLException]
       } else {
         val root = ExceptionUtils.getRootCause(e)
         throw new HiveSQLException("Error running query: " +
           (if (root == null) e.toString else root.toString), e)
       }
   ```
   in all of them?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org