[GitHub] kafka pull request #4116: KAFKA-6105: load client properties in proper order...

[cnZach <gi...@git.apache.org>]

GitHub user cnZach opened a pull request:

    https://github.com/apache/kafka/pull/4116

    KAFKA-6105: load client properties in proper order for EndToEndLatency tool

    Currently, the property file is loaded first, and later a auto generated group.id is used:
    `consumerProps.put(ConsumerConfig.GROUP_ID_CONFIG, "test-group-" + System.currentTimeMillis())`
    
    so even user gives the group.id in a property file, it is not picked up.
    
    Change it to load client properties in proper order: set default values first, then try to load the custom values set in client.properties file.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cnZach/kafka cnZach_KAFKA-6105

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/4116.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4116
    
----
commit 99b6ce136d1c4bafa0f74828583d6b4af6cb0785
Author: Yuexin Zhang <za...@gmail.com>
Date:   2017-10-23T08:11:45Z

    load client properties in proper order: set default values first, then try to load the custom values set in client.properties file

----


---

[GitHub] kafka pull request #4116: KAFKA-6105: load client properties in proper order...

[cnZach <gi...@git.apache.org>]

Github user cnZach closed the pull request at:

    https://github.com/apache/kafka/pull/4116


---