You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "zuston (via GitHub)" <gi...@apache.org> on 2025/09/26 06:10:45 UTC
[PR] improvement(spark): Always reset decompression buffer with explicit position and limit [uniffle]
zuston opened a new pull request, #2634:
URL: https://github.com/apache/uniffle/pull/2634
### What changes were proposed in this pull request?
Refactor the uncompression buffer to reset by the explicit position=0 and limit=len
### Why are the changes needed?
This may be related with the bug #2630
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] improvement(spark): Always reset decompression buffer with explicit position and limit [uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #2634:
URL: https://github.com/apache/uniffle/pull/2634#issuecomment-3345471111
> Could u add a ut for this?
Existing test is enough, this is the refactor for the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] improvement(spark): Always reset decompression buffer with explicit position and limit [uniffle]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2634:
URL: https://github.com/apache/uniffle/pull/2634#issuecomment-3336994507
## Test Results
3 130 files ±0 3 130 suites ±0 6h 48m 13s ⏱️ - 2m 25s
1 205 tests ±0 1 204 ✅ ±0 1 💤 ±0 0 ❌ ±0
15 266 runs ±0 15 251 ✅ ±0 15 💤 ±0 0 ❌ ±0
Results for commit 1b6db723. ± Comparison against base commit 1bd74688.
[test-results]:data:application/gzip;base64,H4sIAE001mgC/03MSw7CMAxF0a1UGTOI7bgFNoPSfKSIflCajBB7Jy1t6PAdW/ctfBjcIu4NAclLI5Yc0nnbHHUK81QElbpRoXJP6weg5GM+lmzMz9TfnuG1WgWvw1BAVnAxznGXmKetyti2+6xVRoZqe5UPOFW3fY6aeRxDKkNA39q+Q+qttA48SkekUHcGnXaeAa5kmQyLzxcJ72vCFAEAAA==
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] improvement(spark): Always reset decompression buffer with explicit position and limit [uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #2634:
URL: https://github.com/apache/uniffle/pull/2634#issuecomment-3336923507
cc @yl09099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] improvement(spark): Always reset decompression buffer with explicit position and limit [uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #2634:
URL: https://github.com/apache/uniffle/pull/2634#issuecomment-3337398215
Could u add a ut for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] improvement(spark): Always reset decompression buffer with explicit position and limit [uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston merged PR #2634:
URL: https://github.com/apache/uniffle/pull/2634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org