You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/23 06:06:34 UTC

[GitHub] [spark] AngersZhuuuu opened a new pull request #27983: [SPARK-15694][SQL][FOLLOW-UP] Implement ScriptTransformation in sql/core (part 1) 

AngersZhuuuu opened a new pull request #27983: [SPARK-15694][SQL][FOLLOW-UP] Implement ScriptTransformation in sql/core (part 1) 
URL: https://github.com/apache/spark/pull/27983
 
 
   ### What changes were proposed in this pull request?
   
    * Renamed `hive/execution/ScriptTransformationExec` to `hive/execution/script/HiveScriptTransformationExec`
    * Added ScriptTransformationExec which would run script operator in SQL mode (without Hive).
   The output of script would be read as a string and column values are extracted by using a delimiter (default : tab character)
    * `ScriptTransformBase` has common code used across `ScriptTransformationExec` and `HiveScriptTransformationExec`
    * For thread writing data to script, ScriptTransformationWriterThread has the core logic. HiveScriptTransformationWriterThread extends that for Hive specific stuff.
    * `ScriptTransformationWriterThread` will be used for Spark SQL. It only supports writing data to script process by serializing column values as tab delimited string
    * `HiveScriptTransformationWriterThread` additionally supports Hive serde
    * Added a Strategy named Scripts which would emit ScriptTransformationExec in physical plans. This would be used in non-Hive mode.
   
   Todo List;
   
   - For Hive, by default only serde's must be used, and for without hive can't use serde
   - Cleanup past hacks that are observed (and people suggest / report)
          -  support use transform with aggregation [SPARK-28227](https://issues.apache.org/jira/browse/SPARK-28227)
          - support array/map as transform's input [SPARK-22435](https://issues.apache.org/jira/browse/SPARK-22435)
   - Use code-gen projection to serialize rows to output stream()
   
   ### Why are the changes needed?
   Support run transform in SQL mode without hive
   
   
   ### Does this PR introduce any user-facing change?
   Yes
   
   
   ### How was this patch tested?
   Added UT
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core
URL: https://github.com/apache/spark/pull/27983#issuecomment-607589882
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core
URL: https://github.com/apache/spark/pull/27983#issuecomment-607589882
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27983: [SPARK-15694][SQL][FOLLOW-UP] Implement ScriptTransformation in sql/core

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27983: [SPARK-15694][SQL][FOLLOW-UP] Implement ScriptTransformation in sql/core
URL: https://github.com/apache/spark/pull/27983#issuecomment-607521027
 
 
   **[Test build #120696 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120696/testReport)** for PR 27983 at commit [`0d9c437`](https://github.com/apache/spark/commit/0d9c43788b0dfd33a9e37fe7c0dc6d1e1d238f86).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on issue #27983: [SPARK-15694][SQL][FOLLOW-UP] Implement ScriptTransformation in sql/core

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27983: [SPARK-15694][SQL][FOLLOW-UP] Implement ScriptTransformation in sql/core
URL: https://github.com/apache/spark/pull/27983#issuecomment-607519383
 
 
   ok to test

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on issue #27983: [SPARK-15694][SQL][FOLLOW-UP] Implement ScriptTransformation in sql/core

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on issue #27983: [SPARK-15694][SQL][FOLLOW-UP] Implement ScriptTransformation in sql/core
URL: https://github.com/apache/spark/pull/27983#issuecomment-602405307
 
 
   @gatorsmile @tejasapatil @wangyum 
   
   I have restart implement ScriptTransform in sql/core now,
   
   Rewrite origin pr in current code. Hope for your review and suggestion

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27983: [SPARK-15694][SQL][FOLLOW-UP] Implement ScriptTransformation in sql/core

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27983: [SPARK-15694][SQL][FOLLOW-UP] Implement ScriptTransformation in sql/core
URL: https://github.com/apache/spark/pull/27983#issuecomment-602405596
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core
URL: https://github.com/apache/spark/pull/27983#issuecomment-607589680
 
 
   **[Test build #120696 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120696/testReport)** for PR 27983 at commit [`0d9c437`](https://github.com/apache/spark/commit/0d9c43788b0dfd33a9e37fe7c0dc6d1e1d238f86).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27983: [SPARK-15694][SQL][FOLLOW-UP] Implement ScriptTransformation in sql/core

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27983: [SPARK-15694][SQL][FOLLOW-UP] Implement ScriptTransformation in sql/core
URL: https://github.com/apache/spark/pull/27983#issuecomment-602405596
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27983: [SPARK-15694][SQL][FOLLOW-UP] Implement ScriptTransformation in sql/core

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27983: [SPARK-15694][SQL][FOLLOW-UP] Implement ScriptTransformation in sql/core
URL: https://github.com/apache/spark/pull/27983#issuecomment-607521385
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25395/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #27983: [SPARK-15694][SQL][FOLLOW-UP] Implement ScriptTransformation in sql/core (part 1)

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #27983: [SPARK-15694][SQL][FOLLOW-UP] Implement ScriptTransformation in sql/core (part 1) 
URL: https://github.com/apache/spark/pull/27983#discussion_r396228748
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/execution/script/ScriptTrnasformationExecSuite.scala
 ##########
 @@ -0,0 +1,195 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.script
+
+import java.sql.{Date, Timestamp}
+
+import org.scalatest.Assertions._
+import org.scalatest.BeforeAndAfterEach
+import org.scalatest.exceptions.TestFailedException
+
+import org.apache.spark.{SparkException, TaskContext, TestUtils}
+import org.apache.spark.rdd.RDD
+import org.apache.spark.sql.Column
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.expressions.{Attribute, AttributeReference}
+import org.apache.spark.sql.catalyst.plans.physical.Partitioning
+import org.apache.spark.sql.execution.{SparkPlan, SparkPlanTest, UnaryExecNode}
+import org.apache.spark.sql.test.{SharedSparkSession, SQLTestUtils}
+import org.apache.spark.sql.types.StringType
+
+class ScriptTransformationSuite extends SparkPlanTest with SharedSparkSession
+  with BeforeAndAfterEach {
+  import testImplicits._
+
+  private val noSerdeIOSchema = new ScriptTransformIOSchema(
+    inputRowFormat = Seq.empty,
+    outputRowFormat = Seq.empty,
+    inputSerdeClass = None,
+    outputSerdeClass = None,
+    inputSerdeProps = Seq.empty,
+    outputSerdeProps = Seq.empty,
+    recordReaderClass = None,
+    recordWriterClass = None,
+    schemaLess = false
+  )
+
+  private var defaultUncaughtExceptionHandler: Thread.UncaughtExceptionHandler = _
+
+  private val uncaughtExceptionHandler = new TestUncaughtExceptionHandler
+
+  protected override def beforeAll(): Unit = {
+    super.beforeAll()
+    defaultUncaughtExceptionHandler = Thread.getDefaultUncaughtExceptionHandler
+    Thread.setDefaultUncaughtExceptionHandler(uncaughtExceptionHandler)
+  }
+
+  protected override def afterAll(): Unit = {
+    super.afterAll()
+    Thread.setDefaultUncaughtExceptionHandler(defaultUncaughtExceptionHandler)
+  }
+
+  override protected def afterEach(): Unit = {
+    super.afterEach()
+    uncaughtExceptionHandler.cleanStatus()
+  }
+
+  test("cat without SerDe") {
+    assume(TestUtils.testCommandAvailable("/bin/bash"))
+
+    val rowsDf = Seq("a", "b", "c").map(Tuple1.apply).toDF("a")
+    checkAnswer(
+      rowsDf,
+      (child: SparkPlan) => new ScriptTransformationExec(
+        input = Seq(rowsDf.col("a").expr),
+        script = "cat",
+        output = Seq(AttributeReference("a", StringType)()),
+        child = child,
+        ioschema = noSerdeIOSchema
+      ),
+      rowsDf.collect())
+    assert(uncaughtExceptionHandler.exception.isEmpty)
+  }
+
+  test("script transformation should not swallow errors from upstream operators (no serde)") {
+    assume(TestUtils.testCommandAvailable("/bin/bash"))
+
+    val rowsDf = Seq("a", "b", "c").map(Tuple1.apply).toDF("a")
+    val e = intercept[TestFailedException] {
+      checkAnswer(
+        rowsDf,
+        (child: SparkPlan) => new ScriptTransformationExec(
+          input = Seq(rowsDf.col("a").expr),
+          script = "cat",
+          output = Seq(AttributeReference("a", StringType)()),
+          child = ExceptionInjectingOperator(child),
+          ioschema = noSerdeIOSchema
+        ),
+        rowsDf.collect())
+    }
+    assert(e.getMessage().contains("intentional exception"))
+    // Before SPARK-25158, uncaughtExceptionHandler will catch IllegalArgumentException
+    assert(uncaughtExceptionHandler.exception.isEmpty)
+  }
+
+
+  test("SPARK-14400 script transformation should fail for bad script command") {
+    assume(TestUtils.testCommandAvailable("/bin/bash"))
+
+    val rowsDf = Seq("a", "b", "c").map(Tuple1.apply).toDF("a")
+
+    val e = intercept[SparkException] {
+      val plan =
+        new ScriptTransformationExec(
+          input = Seq(rowsDf.col("a").expr),
+          script = "some_non_existent_command",
+          output = Seq(AttributeReference("a", StringType)()),
+          child = rowsDf.queryExecution.sparkPlan,
+          ioschema = noSerdeIOSchema)
+      SparkPlanTest.executePlan(plan, sqlContext)
+    }
+    assert(e.getMessage.contains("Subprocess exited with status"))
+    assert(uncaughtExceptionHandler.exception.isEmpty)
+  }
+
+  test("SPARK-24339 verify the result after pruning the unused columns") {
+    val rowsDf = Seq(
+      ("Bob", 16, 176),
+      ("Alice", 32, 164),
+      ("David", 60, 192),
+      ("Amy", 24, 180)).toDF("name", "age", "height")
+
+    checkAnswer(
+      rowsDf,
+      (child: SparkPlan) => new ScriptTransformationExec(
+        input = Seq(rowsDf.col("name").expr),
+        script = "cat",
+        output = Seq(AttributeReference("name", StringType)()),
+        child = child,
+        ioschema = noSerdeIOSchema
+      ),
+      rowsDf.select("name").collect())
+    assert(uncaughtExceptionHandler.exception.isEmpty)
+  }
+
+  test("SPARK-25990: TRANSFORM should handle different data types correctly") {
+    assume(TestUtils.testCommandAvailable("python"))
+    val scriptFilePath = getTestResourcePath("test_script.py")
+
+    withTempView("v") {
+      val df = Seq(
+        (1, "1", 1.0, BigDecimal(1.0), new Timestamp(1), Date.valueOf("2015-05-21")),
+        (2, "2", 2.0, BigDecimal(2.0), new Timestamp(2), Date.valueOf("2015-05-22")),
+        (3, "3", 3.0, BigDecimal(3.0), new Timestamp(3), Date.valueOf("2015-05-23"))
+      ).toDF("a", "b", "c", "d", "e", "f") // Note column d's data type is Decimal(38, 18)
+      df.createTempView("v")
+
 
 Review comment:
   Here add test case of Timestamp and DateType

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27983: [SPARK-15694][SQL][FOLLOW-UP] Implement ScriptTransformation in sql/core

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27983: [SPARK-15694][SQL][FOLLOW-UP] Implement ScriptTransformation in sql/core
URL: https://github.com/apache/spark/pull/27983#issuecomment-602405926
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27983: [SPARK-15694][SQL][FOLLOW-UP] Implement ScriptTransformation in sql/core

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27983: [SPARK-15694][SQL][FOLLOW-UP] Implement ScriptTransformation in sql/core
URL: https://github.com/apache/spark/pull/27983#issuecomment-607521379
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on issue #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on issue #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core
URL: https://github.com/apache/spark/pull/27983#issuecomment-607593288
 
 
   > Hi, @AngersZhuuuu . This is too big as a follow-up. Please create a new JIRA issue for this.
   
   Seems not need to create new jira? just delete follow-up?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on issue #27983: [SPARK-15694][SQL][FOLLOW-UP] Implement ScriptTransformation in sql/core

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27983: [SPARK-15694][SQL][FOLLOW-UP] Implement ScriptTransformation in sql/core
URL: https://github.com/apache/spark/pull/27983#issuecomment-607519350
 
 
   Hi, @AngersZhuuuu . This is too big as a follow-up. Please create a new JIRA issue for this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core
URL: https://github.com/apache/spark/pull/27983#issuecomment-607589889
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120696/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core
URL: https://github.com/apache/spark/pull/27983#issuecomment-607589889
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120696/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27983: [SPARK-15694][SQL][FOLLOW-UP] Implement ScriptTransformation in sql/core

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27983: [SPARK-15694][SQL][FOLLOW-UP] Implement ScriptTransformation in sql/core
URL: https://github.com/apache/spark/pull/27983#issuecomment-602405926
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on issue #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on issue #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core
URL: https://github.com/apache/spark/pull/27983#issuecomment-607599637
 
 
   @dongjoon-hyun 
   In latest test,  
   ```
   org.apache.spark.sql.execution.script.ScriptTransformationSuite.SPARK-14400 script transformation should fail for bad script command
   ```
   Seem sometimes it won't catch the subprocess's exception.
   I tried a lot of times, sometimes failed, sometimes success. May have problem about catch subproc's exception.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27983: [SPARK-15694][SQL][FOLLOW-UP] Implement ScriptTransformation in sql/core

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27983: [SPARK-15694][SQL][FOLLOW-UP] Implement ScriptTransformation in sql/core
URL: https://github.com/apache/spark/pull/27983#issuecomment-607521379
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27983: [SPARK-15694][SQL][FOLLOW-UP] Implement ScriptTransformation in sql/core

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27983: [SPARK-15694][SQL][FOLLOW-UP] Implement ScriptTransformation in sql/core
URL: https://github.com/apache/spark/pull/27983#issuecomment-607521385
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25395/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core
URL: https://github.com/apache/spark/pull/27983#issuecomment-607521027
 
 
   **[Test build #120696 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120696/testReport)** for PR 27983 at commit [`0d9c437`](https://github.com/apache/spark/commit/0d9c43788b0dfd33a9e37fe7c0dc6d1e1d238f86).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org