You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by NicoK <gi...@git.apache.org> on 2017/07/12 12:18:06 UTC
[GitHub] flink pull request #4309: [FLINK-7166][avro] cleanup generated test classes ...
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4309
[FLINK-7166][avro] cleanup generated test classes in the cleanup phase
Maven neither cleaned up generated avro classes used by tests nor did it replace
them with new ones after the avro dependency change causing troubles to build
the project. Although the target directory inside `src` is unusual, we keep it
for now but at least delete these files in the cleanup stage so that a
`mvn clean install` always works.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-7166
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4309.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4309
----
commit d6aec8f4d9666bdf912c768190033cf521b40b0a
Author: Nico Kruber <ni...@data-artisans.com>
Date: 2017-07-12T12:15:24Z
[FLINK-7166][avro] cleanup generated test classes in the cleanup phase
Maven neither cleaned up generated avro classes used by tests nor did it replace
them with new ones after the avro dependency change causing troubles to build
the project. Although the target directory inside `src` is unusual, we keep it
for now but at least delete these files in the cleanup stage so that a
`mvn clean install` always works.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4309: [FLINK-7166][avro] cleanup generated test classes in the ...
Posted by NicoK <gi...@git.apache.org>.
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4309
did the rebase and it looks good :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4309: [FLINK-7166][avro] cleanup generated test classes in the ...
Posted by NicoK <gi...@git.apache.org>.
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4309
That would make sense and I was going that way at first. It is spread over some of the project files though and there was something about eclipse having problems with it (although the last time, we tried, using eclipse for developing Flink didn't work anymore).
So in the end, changing this may be more beautiful but we don't really gain much by it, do we? Only, potentially, some problems.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4309: [FLINK-7166][avro] cleanup generated test classes in the ...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4309
Thanks for the fix. I think this LGTM, +1.
@NicoK could you rebase on the latest master to incorproate the new test profiles (just to make sure nothing bad is affected by this change, although I don't really expect it)?
After a green run I'll merge this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4309: [FLINK-7166][avro] cleanup generated test classes in the ...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4309
Merging ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4309: [FLINK-7166][avro] cleanup generated test classes ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4309
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4309: [FLINK-7166][avro] cleanup generated test classes in the ...
Posted by bowenli86 <gi...@git.apache.org>.
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/4309
I ran into this too. Thanks for the PR!
Shall we also create a ticket to move generated files out of `src`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---