You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jay Zhuang (JIRA)" <ji...@apache.org> on 2019/04/24 19:15:00 UTC
[jira] [Commented] (CASSANDRA-15098) Endpoints no longer owning
tokens are not removed for vnode
[ https://issues.apache.org/jira/browse/CASSANDRA-15098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825447#comment-16825447 ]
Jay Zhuang commented on CASSANDRA-15098:
----------------------------------------
Here is an utest to reproduce the problem and a purposed fix, please review:
| Branch | uTest |
| [15098-3.0|https://github.com/cooldoger/cassandra/tree/15098-3.0] | [!https://circleci.com/gh/cooldoger/cassandra/tree/15098-3.0.svg?style=svg!|https://circleci.com/gh/cooldoger/cassandra/tree/15098-3.0] |
| [15098-3.11|https://github.com/cooldoger/cassandra/tree/15098-3.11] | [!https://circleci.com/gh/cooldoger/cassandra/tree/15098-3.11.svg?style=svg!|https://circleci.com/gh/cooldoger/cassandra/tree/15098-3.11] |
| [15098-trunk|https://github.com/cooldoger/cassandra/tree/15098-trunk] | [!https://circleci.com/gh/cooldoger/cassandra/tree/15098-trunk.svg?style=svg!|https://circleci.com/gh/cooldoger/cassandra/tree/15098-trunk] |
> Endpoints no longer owning tokens are not removed for vnode
> -----------------------------------------------------------
>
> Key: CASSANDRA-15098
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15098
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Gossip
> Reporter: Jay Zhuang
> Assignee: Jay Zhuang
> Priority: Normal
>
> The logical here to remove endpoints no longer owning tokens is not working for multiple tokens (vnode):
> https://github.com/apache/cassandra/blob/06209037ea56b5a2a49615a99f1542d6ea1b2947/src/java/org/apache/cassandra/service/StorageService.java#L2505
> And it's very expensive to copy the tokenmetadata for every check.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org